User preference to adjust diff colors for color blindness #25680
Description
Feature Description
For red-green-blind people, the colors in a diff are difficult or impossible to distinguish.
Therefore it would be good if a user can specify in the settings that he is either color blind or can choose individual colors.
Here is an example of what a custom diff can look like.
Screenshots
No response
Metadata
Metadata
Assignees
Labels
Type
Projects
Milestone
Relationships
Development
No branches or pull requests
Participants
Activity
delvh commentedon Jul 4, 2023
I don't think that's the task of a setting.
Please think about adding a custom color-blind-friendly theme instead.
That will do the same thing in a non-intrusive way.
Once you have developed it, please also add a PR to https://gitea.com/gitea/awesome-gitea so that others can use it as well.
silverwind commentedon Jul 4, 2023
High-contrast theme variants is something to consider for the future, but I don't think our themeing infrastructure is there yet to support it. First we need a way to set individual "default light" and "default dark" themes, then we can talk about additional variants.
silverwind commentedon Jul 5, 2023
Notably, GitHub has two variants to each theme:
Instead of separate theme clones, these could be options in the theme, so for example when
<html>hasdata-colorblind=trueattribute, a selector:root[data-colorblind] { --color-red: #f00}can take effect to override variables in the base theme. This way, we avoid duplicating the whole theme and still have a fallback to base colors in case the theme does not have these variants.techknowlogick commentedon Jul 5, 2023
fwiw there are many types of colour blindness: https://www.colourblindawareness.org/colour-blindness/types-of-colour-blindness/ so an enum should be used vs a bool
status/needs-feedbackthat were last updated more than a month ago GiteaBot/gitea-backporter#108Infinoid commentedon Jan 29, 2024
I've been looking at this recently. Our company has multiple color-blind people, and it would be nice if the Gitea UI were more legible to them. There are a few specific areas we've run into problems. And I have a question about how themes work, versus how they SHOULD work.
There seem to be 4 classes in the Gitea UI which affect colors of buttons and status boxes and such. These are "primary", "secondary", "red" and "green". It's the "red" and "green" ones that are confusing in the context of color-blind themes.
Example: the PR page for a PR which is open but not ready to merge, rendered for an admin (who can merge anyway, overriding branch protection rules). This page has a nice "open" label near the top is marked
class="ui green label issue-state-label". The merge button at the bottom is meant to look scary, and is markedclass="ui buttons merge-button red".A theme for red-green color-blind people would assign different colors to both of these.
So, would you consider a PR which added a theme that sets
--color-redto grey, and--color-greento blue? Or would these class terms need to be cleaned up first, before such a PR could be approved?In any case, I'm wondering if using qualitative words, like "good" and "bad", or maybe "ready" and "override", or "happy" and "scary" or something, would be less confusing than "red" and "green".
wxiaoguang commentedon Apr 21, 2024
-> Initial support for colorblind-friendly themes #30625
Initial support for colorblindness-friendly themes (#30625)