Dependencies only show one issue for each other repo

[colejohnson66]

Description

The "blocks/dependencies" area of issues only shows the three oldest additions to the list, even if there are more. The issue log does show there being more than three "new dependencies" being added. It appears like the code naively adds a LIMIT 3 to the database call with no regard for the real count.

The entire list should be viewable, and it should be sorted differently than the order of insertion in the database.

Gitea Version

1.20.5

Can you reproduce the bug on the Gitea demo site?

Untested

Log Gist

No response

Screenshots

This screenshot shows only three issues as being blocked by the currently viewed one. The current issue actually blocks about a half-dozen. As above, these are the first three additions to the list, and appear in that order.

Git Version

No response

Operating System

No response

How are you running Gitea?

N/A

Database

MySQL/MariaDB

[colejohnson66]

I can't easily identify why this occurs. The template as well as the code to retrieve them do not place a limit on the list's length.

[lng2020]

this PR #17935 has several bugs and typos. It really should add some tests to ensure its behavior.

[colejohnson66]

Looking at your new PR and the linked PR, I can indeed confirm that the issue (no pun intended) is that only the first added issue for each other repository is shown. And they are shown in order of repository ID.

So, for my screenshot, #‍15 was from repo ID 2, #‍856 from ID 3, and #‍23 from ID 4. In addition, issue #‍23 for repository ID 4 was actually the first to be added to the list of dependencies, but shows up last.

[lng2020]

That make much more sense. Your screenshot is strictly followed the old code logic.

[KazzmanK]

There is much to add to the Dependency list UI issues.
on try.gitea.io I'm unable to reproduce my problems
on our 1.20.5 it is shows Not found, or, when I type, it shows strange results in dropdown.

In sibling issue it indeed displays it, but I need to reference other issue there

So, to add reference to issue 26 in my first issue, I have to try referencing issue 25, it shows issue 26 in dropdown and it is done !
But after what when I try to repeat the trick in other issue with filter string 25 it starts showing issue 81 and it is not possible to pick issue 26 anymore.
Total mess!
Is there something fixed in upcoming releases ?

[KazzmanK]

It is still rising questions on 1.21.0+rc2-22-g2d2a5657e

As well as on
1.22.0+dev-249-ge75b89ea6

It just shows some random results in dropdown , and misses required issues.