Skip to content

Mirrors should not migrate refs/pull and then the relative commits will be gone. #27961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lunny opened this issue Nov 8, 2023 · 2 comments · Fixed by #32659
Closed

Mirrors should not migrate refs/pull and then the relative commits will be gone. #27961

lunny opened this issue Nov 8, 2023 · 2 comments · Fixed by #32659
Assignees
@lunny
Labels
type/bug

Comments

@lunny
Copy link
Member

lunny commented Nov 8, 2023

Description

No response

Gitea Version

main

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

Some filters should be applied in https://github.com/go-gitea/gitea/blob/main/services/mirror/mirror_pull.go#L225-L235 to not sync refs/pull for git mirror.

Database

None
@lunny lunny added the type/bug label Nov 8, 2023
@ericLemanissier
Copy link
Contributor

Hi @lunny
It looks like this still happens, in spite of

gitea/services/mirror/mirror_pull.go

Lines 478 to 480 in 846f618

if result.refName.IsPull() {
continue
}

image
Is there a known work-around ?

@lunny lunny self-assigned this Nov 27, 2024
@lunny lunny mentioned this issue Nov 27, 2024
Merged
lunny added a commit that referenced this issue Nov 28, 2024
@lunny
Don't create action when syncing mirror pull refs (#32659)
00f8090 
Fix #27961
@ericLemanissier
Copy link
Contributor

Thanks ! I'll test it when it's released

GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Nov 28, 2024
@lunny @GiteaBot
Don't create action when syncing mirror pull refs (go-gitea#32659)
cdd1c12 
Fix go-gitea#27961
@GiteaBot GiteaBot mentioned this issue Nov 28, 2024
Merged
lunny added a commit that referenced this issue Nov 28, 2024
@GiteaBot @lunny
Don't create action when syncing mirror pull refs (#32659) (#32664)
27489f2 
Backport #32659 by @lunny

Fix #27961

Co-authored-by: Lunny Xiao <[email protected]>
@ericLemanissier ericLemanissier mentioned this issue Jan 10, 2025
Closed
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Feb 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@lunny lunny

Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't create action when syncing mirror pull refs lunny/gitea
2 participants
@lunny @ericLemanissier