Codeowner change detection doesn't work for outdated branches

[otbutz]

Description

If the branch of a pull request is behind its target branch, any changes from missing commits on the target branch will also trigger their associated rules.

The codeowner detection should rather be based on the actual diff output that is shown in the pull request page.

Gitea Version

1.21.0

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

Binary started via systemd behind a caddy reverse proxy.

Database

None

[bt90]

@cl-bvl I wonder if this intentional behaviour or should the list of files be computed from the actual diff?

[m3rtl]

Is there anything new on this?

[zowers]

owners of files unrelated to the PR are notified, please consider fixing

[zowers]

Caused by how list of changed files is computed: between base branch and pr branch

	changedFiles, err := repo.GetFilesChangedBetween(git.BranchPrefix+pr.BaseBranch, pr.GetGitRefName())

here:
https://github.com/go-gitea/gitea/pull/24910/files#diff-bc78d680355495193dadf6796c153e5f1bf55e91c3005e0c3055ee72a7fe2c7cR931 (#24921 )

same in main:

gitea/models/issues/pull.go

Line 925 in 0900c15

changedFiles, err := repo.GetFilesChangedBetween(git.BranchPrefix+pr.BaseBranch, pr.GetGitRefName())

probably pr.HeadCommitID must be used instead of git.BranchPrefix+pr.BaseBranch

[lunny]

This has been resolved by #29783