Skip to content

Admin config page UI regression #30524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wxiaoguang opened this issue Apr 16, 2024 · 2 comments · Fixed by #30527
Closed

Admin config page UI regression #30524

wxiaoguang opened this issue Apr 16, 2024 · 2 comments · Fixed by #30527
Labels
type/bug

Comments

@wxiaoguang
Copy link
Contributor

image
@silverwind
Copy link
Member

Only a problem on light theme.

@silverwind
Copy link
Member

For comparison, original fomantic ui:

image image

So I think we add only that border.

@silverwind silverwind mentioned this issue Apr 16, 2024
Merged
silverwind added a commit that referenced this issue Apr 16, 2024
@silverwind
Tweak and fix toggle checkboxes (#30527)
5ccd042 
Fixes: #30524. Slightly restyled
them so that the "knob" is contained inside the background.

<img width="179" alt="Screenshot 2024-04-16 at 21 58 09"
src="https://github.com/go-gitea/gitea/assets/115237/be94517b-9cb7-46e2-ae96-fcf6767ce4ba">
<img width="187" alt="Screenshot 2024-04-16 at 21 58 50"
src="https://github.com/go-gitea/gitea/assets/115237/c13a1959-5c5a-4e88-9225-e5f6fb72e3e0">
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Apr 16, 2024
@silverwind @GiteaBot
Tweak and fix toggle checkboxes (go-gitea#30527)
e2abcff 
Fixes: go-gitea#30524. Slightly restyled
them so that the "knob" is contained inside the background.

<img width="179" alt="Screenshot 2024-04-16 at 21 58 09"
src="https://github.com/go-gitea/gitea/assets/115237/be94517b-9cb7-46e2-ae96-fcf6767ce4ba">
<img width="187" alt="Screenshot 2024-04-16 at 21 58 50"
src="https://github.com/go-gitea/gitea/assets/115237/c13a1959-5c5a-4e88-9225-e5f6fb72e3e0">
@GiteaBot GiteaBot mentioned this issue Apr 16, 2024
Merged
silverwind added a commit that referenced this issue Apr 17, 2024
@GiteaBot @silverwind
Tweak and fix toggle checkboxes (#30527) (#30531)
d5525b7 
Backport #30527 by @silverwind

Fixes: #30524. Slightly restyled
them so that the "knob" is contained inside the background.

<img width="179" alt="Screenshot 2024-04-16 at 21 58 09"
src="https://github.com/go-gitea/gitea/assets/115237/be94517b-9cb7-46e2-ae96-fcf6767ce4ba">
<img width="187" alt="Screenshot 2024-04-16 at 21 58 50"
src="https://github.com/go-gitea/gitea/assets/115237/c13a1959-5c5a-4e88-9225-e5f6fb72e3e0">

Co-authored-by: silverwind <[email protected]>
DennisRasey pushed a commit to DennisRasey/forgejo that referenced this issue Apr 22, 2024
@GiteaBot @silverwind @earl-warren
Tweak and fix toggle checkboxes (#30527) (#30531)
6724373 
Backport #30527 by @silverwind

Fixes: go-gitea/gitea#30524. Slightly restyled
them so that the "knob" is contained inside the background.

<img width="179" alt="Screenshot 2024-04-16 at 21 58 09"
src="https://github.com/go-gitea/gitea/assets/115237/be94517b-9cb7-46e2-ae96-fcf6767ce4ba">
<img width="187" alt="Screenshot 2024-04-16 at 21 58 50"
src="https://github.com/go-gitea/gitea/assets/115237/c13a1959-5c5a-4e88-9225-e5f6fb72e3e0">

Co-authored-by: silverwind <[email protected]>
(cherry picked from commit d5525b714322bf8a39334b045dffe368c6207e01)
DennisRasey pushed a commit to DennisRasey/forgejo that referenced this issue Apr 22, 2024
@silverwind @algernon
Tweak and fix toggle checkboxes (#30527)
cfb8617 
Fixes: go-gitea/gitea#30524. Slightly restyled
them so that the "knob" is contained inside the background.

<img width="179" alt="Screenshot 2024-04-16 at 21 58 09"
src="https://github.com/go-gitea/gitea/assets/115237/be94517b-9cb7-46e2-ae96-fcf6767ce4ba">
<img width="187" alt="Screenshot 2024-04-16 at 21 58 50"
src="https://github.com/go-gitea/gitea/assets/115237/c13a1959-5c5a-4e88-9225-e5f6fb72e3e0">

(cherry picked from commit 5ccd042f7080e1f4ef4b96591e1b1002a4826115)
uli-heller pushed a commit to uli-heller/forgejo that referenced this issue Apr 24, 2024
@GiteaBot @silverwind @uli-heller
Tweak and fix toggle checkboxes (#30527) (#30531)
67025ed 
Backport #30527 by @silverwind

Fixes: go-gitea/gitea#30524. Slightly restyled
them so that the "knob" is contained inside the background.

<img width="179" alt="Screenshot 2024-04-16 at 21 58 09"
src="https://github.com/go-gitea/gitea/assets/115237/be94517b-9cb7-46e2-ae96-fcf6767ce4ba">
<img width="187" alt="Screenshot 2024-04-16 at 21 58 50"
src="https://github.com/go-gitea/gitea/assets/115237/c13a1959-5c5a-4e88-9225-e5f6fb72e3e0">

Co-authored-by: silverwind <[email protected]>
(cherry picked from commit d5525b714322bf8a39334b045dffe368c6207e01)
@wxiaoguang wxiaoguang mentioned this issue May 9, 2024
Closed
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tweak and fix toggle checkboxes silverwind/gitea
2 participants
@silverwind @wxiaoguang