Skip to content

Selected workflow will not be highlighted #30578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yp05327 opened this issue Apr 19, 2024 · 4 comments · Fixed by #30897
Closed

Selected workflow will not be highlighted #30578

yp05327 opened this issue Apr 19, 2024 · 4 comments · Fixed by #30897
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Milestone
1.22.0

Comments

@yp05327
Copy link
Contributor

yp05327 commented Apr 19, 2024

Feature Description

image
IIRC, it will be highlighted when workflow was selected before.

Screenshots

No response
@yp05327 yp05327 added type/bug topic/ui Change the appearance of the Gitea UI labels Apr 19, 2024
@yp05327
Copy link
Contributor Author

yp05327 commented Apr 26, 2024 •
edited
Loading

It seems that this is caused by #30325

active item background is overridden by .ui.vertical.menu .item
image

@lunny
Copy link
Member

lunny commented Apr 26, 2024

Looks like not only this menu, many other menus have the same problem.

@yp05327
Copy link
Contributor Author

yp05327 commented May 8, 2024

@lunny
I think we should add this to 1.22 milestone.

@lunny lunny added this to the 1.22.0 milestone May 8, 2024
@wxiaoguang wxiaoguang mentioned this issue May 8, 2024
Merged
@wxiaoguang
Copy link
Contributor

-> Add missing menu active item background back #30897

wxiaoguang added a commit that referenced this issue May 8, 2024
@wxiaoguang
Add missing menu active item background back (#30897)
ed0fc27 
Fix #30578
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue May 8, 2024
@wxiaoguang @GiteaBot
Add missing menu active item background back (go-gitea#30897)
edb49a5 
Fix go-gitea#30578
@GiteaBot GiteaBot mentioned this issue May 8, 2024
Merged
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.22.0
Development

Successfully merging a pull request may close this issue.

Add missing menu active item background back wxiaoguang/gitea
3 participants
@lunny @wxiaoguang @yp05327