Editing text in Safari/macOS gives JavaScript error: undefined is not an object (evaluating 'navigator.clipboard write')

[DD-P]

Description

On typing, the web page displays the above JavaScript clipboard error with eg (http://rad.gitea:12080/assets/js/monaco.14c11225.js @ 415:16905).

This appears to relate to the update of monaco-editor from 0.44.0 to 0.45.0 in ce55a74

I suspect this only occurs when serving over http rather than https as the error does not occur on https://try.gitea.io/

Presumably monaco-editor is now using the async clipboard API. See https://webkit.org/blog/10855/async-clipboard-api/

Gitea Version

1.22.0-rc1

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

Git Version

2.40.1

Operating System

Ubuntu 23.10

How are you running Gitea?

Dockerised on Proxmox 8.2

Database

MySQL/MariaDB

[wxiaoguang]

Could you try 1.22-nightly? The editor has been updated to #30713, I can not reproduce the JS error by my Safari now.

Docker images could be got from https://hub.docker.com/r/gitea/gitea/tags?page=&page_size=&ordering=&name=1.22-nightly, binary 1.22 nightly could be downloaded from https://dl.gitea.com/gitea/1.22/

By the way @techknowlogick , would we like to rename the directory to 1.22-nightly to match the docker image names?

[wxiaoguang]

Oops, sorry that #30713 is not backported to 1.22 ..... 😭

Checked again. 30713 is in 1.22-nightly (I misread ....)

[DD-P]

Thank you for quick response. No 1.22-nightly still errors.

[wxiaoguang]

Hmm, it seems to be a longstanding problem in monaco-editor, the code is 3-year old. (TBH, I have no idea why it only happens in 1.22/main .....)

https://github.com/microsoft/vscode/blame/53c1b7b87c7d8aebafdd1e2fbbdbdb04a95612b3/src/vs/platform/clipboard/browser/clipboardService.ts#L55C10-L55C42

Until upstream has a fix (microsoft/monaco-editor#4496), we could ignore such error by: Do not show monaco JS errors #30862

[wxiaoguang]

1.22 nightly including #30866 is ready.

Welcome to take a try and if there is still any problem, please help to report. Thank you very much!

[DD-P]

Fix in nightly seems perfect. Thank you very much for fixing this so promptly.