-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Closed
Labels
Description
Description
The value of Camo#Allways
seems to have a typo. It should be Camo#Always
with one l
.
Can be found here:
https://github.com/search?q=repo%3Ago-gitea%2Fgitea%20ALLWAYS&type=code
Line 12 in 12cb1d2
Allways bool - `ALLWAYS`: **false**: Set to true to use camo for both HTTP and HTTPS content, otherwise only non-HTTPS URLs are proxied Line 41 in 12cb1d2
(setting.Camo.Allways || lnkURL.Scheme != "https") { gitea/custom/conf/app.example.ini
Line 526 in 12cb1d2
;ALLWAYS = false
SuperSandro2000
Metadata
Metadata
Assignees
Labels
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
charles7668 commentedon Jul 6, 2024
I don't think this is a typo. In this configuration context, "ALLWays" might mean "all_ways".
lunny commentedon Aug 14, 2024
Close as @charles7668 's feedback.
wxiaoguang commentedon Aug 14, 2024
But it is indeed a typo.
all_ways
should beALL_WAYS
according to the naming style (underline between words).SuperSandro2000 commentedon Sep 20, 2024
Since gitea has no strict config validation, it is really easy to miss configure this.
[camo].Allways
to[camo].Always
#32097Use camo.Always instead of camo.Allways (go-gitea#32097)
Use camo.Always instead of camo.Allways (go-gitea#32097)