Code Editor Line number over 9999 not displayed correctly

[jonde99]

Description

Any file over 10000 lines displays the line numbers beyond 9999 incorrectly in the online editor.

Gitea Version

1.22.1

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

Review mode:

Edit Mode:

Git Version

1.22.1

Operating System

Redhat

How are you running Gitea?

docker.

Database

MySQL/MariaDB

[yp05327]

It seems that this is caused by the font?

[yp05327]

If you remove Consolas in --fonts-monospace it will be correct.

[jonde99]

If you remove Consolas in --fonts-monospace it will be correct.

Thanks. I will ask our admin to remove this line.

[jonde99]

I played with this option, and it doesn't really fix it, it just delays the problem until there are 6 digits in the line number.
The correct solution would be to allow the column to expand, but I cannot figure out where that is done.

[yp05327]

I didn’t try 6 digits…. Maybe we need to check it first in https://microsoft.github.io/monaco-editor/playground.html?source=v0.50.0#example-creating-the-editor-hello-world

[yp05327]

In online demo, it works well.

[palto42]

@yp05327

In online demo, it works well.

Are you sure you tried the editor view an not just the text preview?
I also tried the demo server and can confirm that I face the same issue as on my local Gitea instance.
https://demo.gitea.com/palto42/big_text/_edit/main/dummy_text_file.txt

No issues in https://microsoft.github.io/monaco-editor/playground.html?source=v0.50.0#example-creating-the-editor-hello-world

[lunny]

I can confirm the problem.

[yp05327]

@yp05327

In online demo, it works well.

Are you sure you tried the editor view an not just the text preview? I also tried the demo server and can confirm that I face the same issue as on my local Gitea instance. https://demo.gitea.com/palto42/big_text/_edit/main/dummy_text_file.txt

I mean it works well in monaco editor playground, but not Gitea.

[charles7668]

It seems the issue has been fixed by #31940.

[yp05327]

I tested it in the latest version, it is fixed!

I will close this issue.