PR Files changed view: "Filter by commit" Dropdown not visible after clicking the button

[sebastian-sauer]

Description

The "Filter by commit" dropdown on the PR files changed view will not be shown if you click on the button.

The div gets the visible class when clicking the button but this does not show the dropdown. (display:none is still used from .dropdown class)

Just tested this on demo.gitea.com:

https://demo.gitea.com/TEST_CODEOWNERS/gitea/pulls/1/files and then click on the commits button.

Gitea Version

1.22.1

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

Gitea binary, demo.gitea.com

Database

None

[yp05327]

I'm sorry, What is Commits dropdown? Do you mean this?

Or can you provide some screenshots?

[sebastian-sauer]

Yes - exactly. The "Filter by commit" dropdown. (i've updated the description, too)

[sebastian-sauer]

Caused by the change in #31281 (commit 482fee2)

The transition class has been removed. When adding the class, the dropdown will be visible.

@wxiaoguang as i don't know the reason behind the change i'm not sure if readding the transition class would break anything. Any thoughts on this?

[wxiaoguang]

Actually it was an abuse of dropdown. The dropdown classes (like "transition visible") should be managed by the Fomantic UI JS, but not by Vue. Fomantic UI doesn't work directly with Vue.

[wxiaoguang]

-> Fix "Filter by commit" Dropdown #31695