Skip to content

Changes lost when updating title or comment and navigating #32223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hakito opened this issue Oct 9, 2024 · 2 comments · Fixed by #32920
Closed

Changes lost when updating title or comment and navigating #32223

hakito opened this issue Oct 9, 2024 · 2 comments · Fixed by #32920
Assignees
@Lieslot
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Milestone
1.24.0

Comments

@hakito
Copy link
Contributor

hakito commented Oct 9, 2024

Description

When adding a new comment for an issue, the browser navigation is blocked with a warning that changes will be lost.

This warning does not occur when editing issue titles or when editing an existing comment.

Gitea Version

1.22.3

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

Docker

Database

None
@hakito hakito added the type/bug label Oct 9, 2024
@yp05327 yp05327 added the topic/ui Change the appearance of the Gitea UI label Oct 10, 2024
@Lieslot
Copy link

Lieslot commented Oct 10, 2024

can i take this issue?

@hakito
Copy link
Contributor Author

hakito commented Oct 10, 2024

Sure - I cannot work on this. I was just reporting it.

TimsDevCorner pushed a commit to TimsDevCorner/gitea that referenced this issue Dec 19, 2024
fix(issue): go-gitea#32223 warn on navigation if currently editing co…
d0726b6 
…mment or title
@TimsDevCorner TimsDevCorner mentioned this issue Dec 19, 2024
Merged
TimsDevCorner pushed a commit to TimsDevCorner/gitea that referenced this issue Dec 19, 2024
fix(issue): go-gitea#32223 warn on navigation if currently editing co…
86f75f0 
…mment or title
TimsDevCorner pushed a commit to TimsDevCorner/gitea that referenced this issue Dec 19, 2024
Warn on navigation if currently editing comment or title (go-gitea#32223
228fec8 
)
TimsDevCorner pushed a commit to TimsDevCorner/gitea that referenced this issue Dec 20, 2024
Revert "Warn on navigation if currently editing comment or title (go-…
cb1e538 
…gitea#32223)"

This reverts commit 228fec8.
TimsDevCorner pushed a commit to TimsDevCorner/gitea that referenced this issue Dec 20, 2024
Warn on navigation if currently editing comment or title (go-gitea#32223
fa2dd37 
)
@wxiaoguang wxiaoguang linked a pull request Dec 20, 2024 that will close this issue
show warning on navigation if currently editing comment or title #32920
Merged
wxiaoguang added a commit that referenced this issue Dec 20, 2024
@TimsDevCorner @wxiaoguang
show warning on navigation if currently editing comment or title (#32920
7580bd9 
)

This PR fixes the issue #32223

Make the browser to show the confirm popup, as it does with other forms.

---------

Co-authored-by: Tim Wundenberg <[email protected]>
Co-authored-by: wxiaoguang <[email protected]>
@lunny lunny added this to the 1.24.0 milestone Dec 20, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Mar 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Lieslot Lieslot

Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.24.0
Development

Successfully merging a pull request may close this issue.

show warning on navigation if currently editing comment or title TimsDevCorner/gitea
4 participants
@lunny @hakito @yp05327 @Lieslot