MergePullRequest fails to trigger action

[Fratee]

Description

When merging a pull request the related actions that should trigger on:

on:
  pull_request:
    types: [review_requested]

do not start and the gitea instance throws the following error:

[E] an error occurred while executing the MergePullRequest actions method: gitRepo.GetRefCommitID: object does not exist [id: 32e9eaa99d775bb8922a6ac354a2c9b3dcfe834b, rel_path: ]

This was working fine on 1.22.1

Gitea Version

1.22.2 and 1.22.3

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

2.46.0.windows.1

Operating System

Windows 10

How are you running Gitea?

Self hosted on Windows

Database

None

[Zettat123]

The use of gitRepo.GetRefCommitID was introduced by #31875. But I cannot reproduce this issue. Could you provide some detailed steps to reproduce it?

[lunny]

Wouldn't this workflow be triggered only when some code review requested?

[Zettat123]

Wouldn't this workflow be triggered only when some code review requested?

Yes. But this error occurs before detecting workflows.

gitea/services/actions/notifier_helper.go

Lines 168 to 185 in 0d11ba9

	commitID, err := gitRepo.GetRefCommitID(ref.String())
	if err != nil {
	return fmt.Errorf("gitRepo.GetRefCommitID: %w", err)
	}
	// Get the commit object for the ref
	commit, err := gitRepo.GetCommit(commitID)
	if err != nil {
	return fmt.Errorf("gitRepo.GetCommit: %w", err)
	}
	if skipWorkflows(input, commit) {
	return nil
	}
	var detectedWorkflows []*actions_module.DetectedWorkflow
	actionsConfig := input.Repo.MustGetUnit(ctx, unit_model.TypeActions).ActionsConfig()
	workflows, schedules, err := actions_module.DetectWorkflows(gitRepo, commit,

[Fratee]

I have branch protection and the pull request has been reviewed before merging. The author of the pull request is merging from the gitea interface.

I can share the repo settings and the pipeline trigger. Is this enough?

[Zettat123]

I'd like to know some details about that PR.

1. Was this PR created from a fork?
2. What merge style did you use?
3. Did you merge this PR successfully?
4. Can you reproduce the bug on your Gitea?

[Fratee]

1. No. From a branch in the same repository.
2. Merge with merge commit.
3. Yes but every action connected to the pull merged event did not trigger.
4. Yes, on my self hosted gitea. I've now reverted to 1.22.1 but I can make more tests if you need. For the demo website it takes more time as I need to register a runner also.

[Zettat123]

Are there any workflows that are triggered by other events (like "push")? Can these workflows be triggered properly?

[Fratee]

Push and other events trigger correctly

[Fratee]

Just updated to gitea-1.22.4-windows-4.0-amd64.exe
This version is working fine.

The issue is still present in the GoGit 1.22.4 version

[Zettat123]

The issue is still present in the GoGit 1.22.4 version

Are the versions(1.22.2 and 1.22.3) where you encountered the error also GoGit versions?

[Fratee]

@Zettat123 yes, where gogit versions

[Zettat123]

I can reproduce this issue on the GoGit version so I think it's related to GoGit. I'll try to create a PR to fix it.