Error 500 when updating githooks on mirrored repositories

[johanhugg]

• Gitea version (or commit ref): 1.5.0-dev
• Git version:
• Operating system: Windows 10 x64
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No
  • Not relevant
• Log gist:

Description

Since try.gitea.io isn't working at the time of this writing I couldn't test it. But after looking at the code the issue should exist there too.

When creating a migration, and the repository is a mirror, the code doesn't seem to create the git hook repositories that it expects to find, resulting in a file not found error. Image 1 shows a newly created repository that isn't a mirror. There we can see three folders that contain the three sample hooks that are presented in the Gitea Web GUI (Image 2). A newly created repository that is a mirror, doesn't create these folders (Image 3).

Is this intended? Is there a reason why you shouldn't be able to create git hooks for mirrored repositories?

Screenshots

Image 1

Image 2

Image 3

[rixx]

Seconding this issue/question. I'd love to use a gitea mirror to execute git hooks on my git server host – having git hooks available would be very helpful.

[lunny]

@rixx any logs?

[rixx]

There aren't really any logs – while the frontend shows a large "500", the logs show a 404, which happens when gitea tries to access the non-existing hook directory (usually there is a post-receive.d).

But that's not really the point – I have manually created a post-receive.d, and while I can edit the post receive hook after that, naturally, it doesn't get triggered when the mirror repository gets updated from the upstream repository.

(Motivation: It would be really cool if this was possible – this would allow to do stuff like continuous delivery from your own servers with very little effort for repositories you can't or won't move away from other platforms.)

If I can provide more help, please tell me – unfortunately the mirror update doesn't seem to log anything to the syslog on my machine, so I can't tell you if it has any issues. Mirror updates definitely happen correctly as before.

[MirisWisdom]

Can confirm that this issue appears on 1.5.2 -- both in a Docker and normal environment. Only one relevant line pops up in the log:

2018/10/16 06:07:52 [...ters/repo/setting.go:647 GitHooksEditPost()] [E] hook.Update: open /data/git/repositories/org/project.git/hooks/post-receive.d/post-receive: no such file or directory

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

[rixx]

Regardless, this issue still occurs.

[Multipixelone]

Can confirm I'm also getting this issue on Gitea version 1.5.3

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

[rixx]

Regardless, this issue still occurs.