Closed
Description
Copied from gogs/gogs#3094
- Gitea version (or commit ref): 1.0
- Git version:
- Operating system:
- Database (use
[x]
):- PostgreSQLMySQLSQLite
- Can you reproduce the bug at https://try.gitea.io:
- Yes (provide example URL)NoNot relevant
- Log gist:
Description
I've just created a mirror repository for the rails repo and upon viewing the "Releases" tab, it takes forever to load, sometimes not loading at all which can cause nginx to timeout
Please see #491 as well
Activity
bkcsoft commentedon Dec 28, 2016
not an enhancement, it's a bug. I added release pagniation a while back but I seem to have missed this for-loop here that still loop over all tags 😒 https://github.com/go-gitea/gitea/blob/master/routers/repo/release.go#L77
bkcsoft commentedon Dec 28, 2016
Just flipping that for-loop around and using
ctx.Repo.GitRepo.GetTag(r.TagName)
should make it way faster, and TBH we probably don't need the caching anymore since we're not fetching all tags in one go :)deanpcmad commentedon Dec 28, 2016
Yeah I saw there is pagination so I did wonder why it was slow, that explains it :)
JetpackDuba commentedon Dec 28, 2016
Will you fix it for 1.0.1 or only 1.1? Imo it should be in both :P
lunny commentedon Dec 31, 2016
@deanpcmad, could you please test if #527 resolved your problem since I think there are also some improvements should be taken in future.
deanpcmad commentedon Dec 31, 2016
@lunny sure, is there a build for it?
lunny commentedon Dec 31, 2016
https://dl.gitea.io/gitea/master/, you can find your proper version.
JetpackDuba commentedon Jan 3, 2017
I'm not who opened the issue but in my case using Windows 10 and MSSQL, I've cloned VS CODE github repo and tags page takes 8.8 seconds to load :S
deanpcmad commentedon Jan 3, 2017
Hey, I've just tried it (version 09dabe2) but it is still very slow to load the tags page. If you want to test it yourself locally, mirror the https://github.com/rails/rails repo
make releases faster than before and resolved go-gitea#490
JetpackDuba commentedon Jan 8, 2017
Now it loads in 1sec! That's better!
lunny commentedon Jan 8, 2017
Yes. But it's not perfect. It needs further improvement later.
lunny commentedon Jan 14, 2017
On macOS and sqlite, rails still spent 10s.
lunny commentedon Nov 1, 2017
https://try.gitea.io/lunny/rails/releases. v1.2+ have resolve this issue entirely.