Misleading description at branch protection settings

[jbeyerstedt]

• Gitea version (or commit ref): eb8632b

Description

As also discussed in #6817, the description texts at the branch protection settings do not exactly describe, what will happen. This lead to confusion, when force pushing will be disallowed and when a "normal" push will also not be possible.

The text at the "Enable branch protection" checkbox says:

Prevent deletion and disable Git force pushing to the branch.

This is would be, what I expect to happen, when the checkbox is activated. No-one will be able to delete this branch and force pushing will also not be possible. But the issue is, that any kind of pushing is disabled (which is not, what the text says).

Then there is the "Enable push whitelist" button, which has the explanation:

Allow whitelisted users or teams to bypass push restrictions.
This does not clearly say, if the whitelist will only be allowed to push normally, or also be allowed to force push.

Screenshots

[zeripath]

@jbeyerstedt do you think this just needs a simple change of wording?

If so, could you send a PR with your proposed changes? The settings are around:

gitea/options/locale/locale_en-US.ini

Line 1272 in 2f21bc3

settings.protect_this_branch_desc = Prevent deletion and disable Git force pushing to the branch.

[jbeyerstedt]

Yes, this issue is just about the wording.
Thanks for the hint, where to find the description strings. I'll try to get into this and submit a pull request on the weekend.

[jbeyerstedt]

@zeripath Here's your pull request. (Now opened in the right repo)
And as I write, it was approved by someone. Thanks.