No link to external issue tracker in commit message

[joestr]

• Gitea version (or commit ref): 1.9.0+dev-319-g160e7edd0
• Git version: 2.7.4
• Operating system: Ubuntu 16.04.06
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (https://try.gitea.io/joestr/Testing)
  • No
  • Not relevant
• Log gist:

Description

I linked to an external issue tracker, but if I mention e.g. 'Fixing #2' in a commit message, there is no URL to click.

Screenshots

[joestr]

Ah, the link only appears if I click on the commit itself.

But wouldn't it be more convenient if the links would appear in the commit history and repository overview too? (like in GitHub)

[mrsdizzie]

This was changed in the past due to issues like #6809

And as noted, the links are still present for the commit itself. So was a slight trade off for consistency given the differences in Gitea design and implementation of the links

[joestr]

Would it be possible just to render the '#2' as a valid link? Since the referenced Issue complained about the whole commit message being a link?

[mrsdizzie]

Not without several other changes -- its the same code that sees #2 and #2222222222, or http://reallylongurl.com or 45f588e85dbd3004334718dc9fbbb27675814ee0 as things to link so while you're particular example wouldn't take up the entire title another would.

[mrsdizzie]

Personally I wouldn't mind if they appeared in the commit view since those aren't already links to something else, but I do think they are broken in the repository view and can create a bad experience where it is possible to completely hide/break the link to the commit itself.

They are just disabled for commit view for consistency with repository view since then the issue would just be "its enabled in one similar list view but not the other".

[joestr]

Hm, ok I will accept it then. Thanks for answering my question!

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

[stale]

This issue has been automatically closed because of inactivity. You can re-open it if needed.