Skip to content

Can't see if repository is private #7384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jaqra opened this issue Jul 8, 2019 · 4 comments · Fixed by #8144
Closed

Can't see if repository is private #7384

jaqra opened this issue Jul 8, 2019 · 4 comments · Fixed by #8144
Labels
topic/ui Change the appearance of the Gitea UI
Milestone
1.9.4

Comments

@jaqra
Copy link
Contributor

jaqra commented Jul 8, 2019

When repository is private and has avatar, old lock icon does not show.
Cant see if repository is private or not.

gitea1
gitea
@lunny lunny added the topic/ui Change the appearance of the Gitea UI label Jul 8, 2019
@lunny
Copy link
Member

lunny commented Jul 8, 2019

I think maybe we have two choices:

  • one is composite the two images as one
  • use a different color on repository name.

@lunny lunny added this to the 1.9.0 milestone Jul 8, 2019
@jolheiser
Copy link
Member

What about moving the icon to the right side of the name?
Would that look too cramped?

The archived icon is added to the right when applicable, perhaps they could be grouped together?

Examples (quick hack using browser tools, not a final proposal):
gitea_private
gitea_private_lock

@lunny
Copy link
Member

lunny commented Jul 8, 2019

Just change it like on repository list.

image

Cherrg added a commit to Cherrg/gitea that referenced this issue Jul 8, 2019
@Cherrg
show repo private if avatar is set
4d262cf 
add lock icon lige in repo list

suggested in, fix go-gitea#7384

Signed-off-by: Michael Gnehr <[email protected]>
@Cherrg Cherrg mentioned this issue Jul 8, 2019
Closed
@joelft
Copy link

joelft commented Jul 12, 2019

Any chance this could be moved to 1.10.0 milestone so that 1.9.0 can be released? PR #7387 is already in the 1.10.0 milestone and addresses this issue.

@techknowlogick techknowlogick modified the milestones: 1.9.0, 1.10.0 Jul 15, 2019
@jaqra jaqra mentioned this issue Sep 10, 2019
Merged
lafriks pushed a commit that referenced this issue Sep 13, 2019
@lafriks
[fix #7384] make show private icon when repo avatar set (#8144)
0c47fe2
lafriks pushed a commit that referenced this issue Sep 13, 2019
@lafriks
[fix #7384] make show private icon when repo avatar set (#8144) (#8175)
91ea086
@lafriks lafriks modified the milestones: 1.10.0, 1.9.4 Sep 13, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.9.4
5 participants
@lunny @techknowlogick @lafriks @joelft @jolheiser