Skip to content

[Branch View] put all controll buttons in the same td and make them look similar #7606

@6543

Description

@6543
Member

I think the current implementation takes away too much space from the important left-aligned column because having the buttons inside individual fixed columns introduces unnecessary spacing. I'd put all three buttons in the same td and make them look like this (remove compact class on the pull button):

Then right-align the diffstat and let the leftmost column take the remaining space.

Originally posted by @silverwind in #7520 (comment)

Activity

6543

6543 commented on Jul 24, 2019

@6543
MemberAuthor

blocked by #7602 #7604

silverwind

silverwind commented on Jul 25, 2019

@silverwind
Member

Not sure if that split-up was really necessary. Those two PRs conflict each other unfortunately. Maybe wait till #7602 is merged and then do the remaining changes in #7604 to achieve the equivalent of that screenshot?

6543

6543 commented on Jul 25, 2019

@6543
MemberAuthor

i thought the contributor guidline tells me that if i like to get changes merged quik i should make smal PRs wich a single wish/topic

6543

6543 commented on Jul 25, 2019

@6543
MemberAuthor

i cann still klose the smal PRs and contribute to the big one?

silverwind

silverwind commented on Jul 25, 2019

@silverwind
Member

Yes, small changes get merged faster but your old one wasn't really that big. Anyways, I'd suggest sticking to the plan above. #7602 should probably be landed by tomorrow.

6543

6543 commented on Jul 25, 2019

@6543
MemberAuthor

thx

stale

stale commented on Sep 23, 2019

@stale

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

added
topic/uiChange the appearance of the Gitea UI
issue/confirmedIssue has been reviewed and confirmed to be present or accepted to be implemented
on Sep 30, 2019
6543

6543 commented on Oct 14, 2019

@6543
MemberAuthor

@silverwind ask for reopen this it you like - i curently dont work on this ...

6543

6543 commented on Sep 17, 2020

@6543
MemberAuthor

close this since this is no huge deal and if somebody came with good idears ... he can make it's own issue or pull

locked and limited conversation to collaborators on Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    issue/confirmedIssue has been reviewed and confirmed to be present or accepted to be implementedtopic/uiChange the appearance of the Gitea UI

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @lunny@silverwind@lafriks@6543

        Issue actions

          [Branch View] put all controll buttons in the same `td` and make them look similar · Issue #7606 · go-gitea/gitea