-
-
Notifications
You must be signed in to change notification settings - Fork 6k
Closed
Labels
issue/confirmedIssue has been reviewed and confirmed to be present or accepted to be implementedIssue has been reviewed and confirmed to be present or accepted to be implementedtype/enhancementAn improvement of existing functionalityAn improvement of existing functionality
Milestone
Description
The highlighting code currently assumes a pre > code
structure to work but this is not given for diff and edit previews. Given that pre > code
is problematic in regards to introducing extra whitespace for text selection, I think we should introduce a new exclusive HTML class for syntax highlighting and use that everywhere.
xtendo-org, ivparamonov and garret-gunter
Metadata
Metadata
Assignees
Labels
issue/confirmedIssue has been reviewed and confirmed to be present or accepted to be implementedIssue has been reviewed and confirmed to be present or accepted to be implementedtype/enhancementAn improvement of existing functionalityAn improvement of existing functionality
Type
Projects
Relationships
Development
Select code repository
Activity
lafriks commentedon Aug 3, 2019
How that will work in markdown code sections?
silverwind commentedon Aug 3, 2019
Good point, if the markdown renderer can only output
pre > code
, we have to cover it via.markdown pre > code
. On the other hand, I think some more expermentation is neccessary ifpre > code
can be made to work in regard to copy/paste.stale commentedon Oct 2, 2019
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.
Server-side syntax highlighting for all code (#12047)
Server-side syntax highlighting for all code (go-gitea#12047)