-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Closed
Labels
issue/confirmedIssue has been reviewed and confirmed to be present or accepted to be implementedIssue has been reviewed and confirmed to be present or accepted to be implementedtype/enhancementAn improvement of existing functionalityAn improvement of existing functionality
Description
- Gitea version (or commit ref): 1.9.0
- Git version: 2.17.1
- Operating system: Ubuntu 18.04
- Database (use
[x]
):- PostgreSQLMySQLMSSQLSQLiteTo pick up a draggable item, press the space bar. While dragging, use the arrow keys to move the item. Press space again to drop the item in its new position, or press escape to cancel.
- Can you reproduce the bug at https://try.gitea.io:
- Yes (provide example URL)NoNot relevant (I couldn't access because of slow internet connection)To pick up a draggable item, press the space bar. While dragging, use the arrow keys to move the item. Press space again to drop the item in its new position, or press escape to cancel.
- Log gist:
(not relevant)
Description
In Pull Requests
tab of Gitea repository, there isn't Review Required
text next to who and when the pull request that merge into protected branch with required approvals setting was made. Thus, users don't know whether a PR requires reviews/approvals without having to click into individual PR link.
Screenshots
This screenshot below is from my localhost
Gitea instance on my computer. I created learnPRHomework
repository and set master
branch protected with 1 required approval. Other user (bagas
) open a pull request to this protected branch. Note that there isn't Review Required
text as described in the description above:
On the other hand, PR on GitHub with similar condition have Review Required
text (the screenshot is from linode-docs PRs:
Metadata
Metadata
Assignees
Labels
issue/confirmedIssue has been reviewed and confirmed to be present or accepted to be implementedIssue has been reviewed and confirmed to be present or accepted to be implementedtype/enhancementAn improvement of existing functionalityAn improvement of existing functionality
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
stale commentedon Nov 21, 2019
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.
Show reviews labels - Review required, Approved and Changes requested…
6543 commentedon Apr 26, 2020
I couldn't find the specific pull but its arlready implemented: