View PR in UI always returns 500

[gerritc]

• Gitea version (or commit ref):
• Git version: 1.11.0-rc1
• Operating system: Ubuntu 18.04.3
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No
  • Not relevant
• Log gist:

2020/01/14 05:32:33 routers/repo/pull.go:320:PrepareMergedViewPullInfo() [E] GetCompareInfo: exit status 128 - fatal: ambiguous argument 'a6bb53d9d3ae1d78dd55fdd202aec98c62836485...refs/pull/14/head': unknown revision or path not in the working tree.
        Use '--' to separate paths from revisions, like this:
        'git <command> [<revision>...] -- [<file>...]'

2020/01/14 05:35:18 routers/repo/pull.go:383:PrepareViewPullInfo() [E] GetRefCommitID(refs/pull/84/head): reference not found

Description

After upgrading from 1.10.2 we can't open any pull-request. Gitea returns always a 500. The first error appears when opening a merged pull-request. The second error appears when opening a open pull-request. I can't figure out how to reproduce this situation.

Screenshot

[zeripath]

What version of git are you running?

[zeripath]

Presumably you're running quite an old git and this notation doesn't work on that version. We'll have to figure out the correct call and then send a patch.

[gerritc]

git version: 2.17.1
The problem exists also with current (2.25.0) git version.

[zeripath]

Ok. I thought that this would be an old syntax problem.

The problem line is here:

gitea/modules/git/repo_compare.go

Line 70 in 25531c7

logs, err := NewCommand("log", compareInfo.MergeBase+"..."+headBranch, prettyLogFormat).RunInDirBytes(repo.Path)

Right. Do you have access to Gitea's repositories on the server?

If so can you go to the repo and try:

git rev-parse --verify refs/pull/14/head

What I am presuming is that git can't find that unusual ref, if this works we can then try the git log a6bb53d9d3ae1d78dd55fdd202aec98c62836485...the_sha_you_obtain

If the rev-parse doesn't work I'd like you to check in the refs/pull directory to ensure that the pull does actually have a ref.

If it doesn't then I'm confused as there should be one there - but it would at least explain why there is this problem.

[zeripath]

I think the attached pr fixes this because I suspect what is happening is that the queue gets locked and then the branch never gets updated.

Hopefully that is the issue.

[ryan-shaw]

@zeripath I'm running into the same issue here GetRefCommitID(refs/pull/3/head): reference not found

version 1.10.3, I don't think your patch will fix it as the code you are changing doesn't exist in 1.10.3 > https://github.com/go-gitea/gitea/blob/v1.10.3/modules/sync/unique_queue.go#L47

git show-ref refs/pull/3/head shows no commit when ran (in gitea repos)

Let me know if you need any information.

[lunny]

@ryan-shaw could you reproduce that on try.gitea.io?