move vue and vue-calendar-heatmap to npm/webpack

[silverwind]

• unvendor vue and vue-calendar-heatmap
• remove unused moment.js leftover from previous heatmap version
• ensure webpack loads the full version of vue
• fix vue devmode warning related to 'searchLimit' type
• update vue from 2.6.6 to 2.6.11

I wanted to name the chunk heatmap.js but adblockers don't like that filename [1].

[1] https://github.com/easylist/easylist/blob/3899d5dff33216c0bc64f09ff15d376f346d3e33/easyprivacy/easyprivacy_general.txt#L2095

[silverwind]

There are more Vue warnings visible when webpack builds in development mode. I want to eventually enable us to use that mode, but right now I can not get bindata-less builds to work at all for some reason which is a requirement for that.

[codecov-io]

Codecov Report

Merging #10188 into master will decrease coverage by 0.01%.
The diff coverage is 4.54%.

@@            Coverage Diff             @@
##           master   #10188      +/-   ##
==========================================
- Coverage   43.69%   43.68%   -0.02%     
==========================================
  Files         586      586              
  Lines       81354    81386      +32     
==========================================
+ Hits        35547    35552       +5     
- Misses      41410    41431      +21     
- Partials     4397     4403       +6

Impacted Files	Coverage Δ
routers/user/auth_openid.go	0% <0%> (ø)	⬆️
routers/user/setting/profile.go	39.47% <0%> (-0.8%)	⬇️
models/login_source.go	25.45% <0%> (-0.18%)	⬇️
routers/api/v1/repo/migrate.go	53.93% <0%> (-0.67%)	⬇️
routers/api/v1/admin/org.go	46.73% <0%> (-0.52%)	⬇️
routers/user/auth.go	11.4% <0%> (-0.04%)	⬇️
routers/api/v1/org/org.go	74.45% <0%> (-0.33%)	⬇️
routers/admin/users.go	28.94% <0%> (-0.39%)	⬇️
modules/auth/pam/pam_stub.go	0% <0%> (ø)	⬆️
routers/api/v1/admin/user.go	30.09% <0%> (-0.1%)	⬇️
... and 19 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b50e1d4...8133ea8. Read the comment docs.

[silverwind]

The heatmap should probably be moved to a .vue file at some point and loaded via vue-loader but I don't have the motivation to do that as I'm not that much of a Vue fan 😉.

[silverwind]

@lafriks any feedback? If you like, I can try porting heatmap to a .vue file but would prefer if you do it because vue is black magic to me. I think we can probably streamline the vue initialization parts to a shared vue rendering function.

[lafriks]

Looks good, it can be converted to Vue in other pr

[silverwind]

Rebased. This is good to go from my perspective.

[gary-kim]

The heatmap should probably be moved to a .vue file at some point and loaded via vue-loader but I don't have the motivation to do that as I'm not that much of a Vue fan wink.

Okay, I can do that part. Added to todo.

[silverwind]

@gary-kim I'd prefer if we create a single vue rendering function to be used by all the vue components. I think the current code initializes vue in 2 or 3 different places, which seems like useless code duplication to me. Maybe create src/vue.js and export that rendering function there.

[gary-kim]

I like that idea. Make a single rendering function that imports all the Vue components and calls $mount on them.

[silverwind]

Rebased

[silverwind]

Any more reviews here?

[silverwind]

Rebased once more, good to go.