Improve representation of attachments in issues #11141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e file name and file size (see go-gitea#6500 and go-gitea#6089). Signed-off-by: Matthias Schoettle <[email protected]>
zeripath
reviewed
Apr 19, 2020
GiteaBot
added
the
lgtm/need 2
zeripath
reviewed
Apr 19, 2020
zeripath
approved these changes
Apr 20, 2020
GiteaBot
added
lgtm/need 1
6543
approved these changes
Apr 20, 2020
GiteaBot
added
lgtm/done
|
@mschoettle I think when you created this PR you must have denied project mergers the ability to update the branch in order to merge this. Please either re-allow project mergers to update the branch or update the branch - however, if you do not allow project mergers to update the branch there is a significant chance this will delay our ability to merge this PR. |
|
@zeripath Sorry about that. I was wondering what this setting was useful for. I enabled "Allow edits from maintainers". |
|
ping lg-tm |
|
I was waiting so much for this PR. Thanks! ❤️ |
This was referenced Apr 21, 2020
1 task
lunny
reviewed
May 2, 2020
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
* Improves representation of attachments in issues to a list showing the file name and file size (see go-gitea#6500 and go-gitea#6089). Signed-off-by: Matthias Schoettle <[email protected]> * Fixes indentation. Co-authored-by: zeripath <[email protected]>
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Oct 5, 2020
go-gitea#11141 broke the appearance of dropzone attachments when editting comments causing poorly updating lists. This PR fixes this. Fix go-gitea#12573 Signed-off-by: Andrew Thornton <[email protected]>
zeripath
added a commit
that referenced
this pull request
Oct 10, 2020
#11141 broke the appearance of dropzone attachments when editting comments causing poorly updating lists. This PR fixes this. Fix #12583 Signed-off-by: Andrew Thornton [email protected]
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Oct 11, 2020
Backport go-gitea#13036 go-gitea#11141 broke the appearance of dropzone attachments when editting comments causing poorly updating lists. This PR fixes this. Fix go-gitea#12583 Signed-off-by: Andrew Thornton [email protected]
techknowlogick
added a commit
that referenced
this pull request
Oct 12, 2020
Backport #13036 #11141 broke the appearance of dropzone attachments when editting comments causing poorly updating lists. This PR fixes this. Fix #12583 Signed-off-by: Andrew Thornton [email protected] Co-authored-by: techknowlogick <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the representation of attachments in issues. Credit goes to @renevdzee (#6089 (comment)) for the initial patch.
This fixes issues #6501 and #6089.
The attachments are moved into the content and separated with a divider. Contrary to the original patch I removed the image thumbnail because it was in place of the file size. I tried to replace the icon on the left with the image thumbnail but it's quite big (35px vs. 16px).
What would be nice (is there any way to do that?) if the icon is mime-type related. Right now this is only supported for images.
Alternatively, the attachments could remain in the bottom as shown below. It requires a few CSS changes: