Skip to content

Conversation

CirnoT
Copy link
Contributor

@CirnoT CirnoT commented May 23, 2020

Before:
chrome_2020-05-23_02-21-45

After:
chrome_2020-05-23_02-21-24

Generally the issue was present only for .disabled-for-preview case via CSS from SimpleMDE:

.editor-toolbar.disabled-for-preview a:not(.no-disable) {
    pointer-events: none;
    background: #fff;
    border-color: transparent;
    text-shadow: inherit;
}

I have decided to ensure background is transparent globally, I have no idea why SimpleMDE would want to override backgrounds here, they don't do it for any other case.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 23, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 23, 2020
@lafriks lafriks added the topic/ui Change the appearance of the Gitea UI label May 23, 2020
@lafriks lafriks added this to the 1.13.0 milestone May 23, 2020
@lafriks lafriks merged commit 38c773d into go-gitea:master May 23, 2020
@lafriks
Copy link
Member

lafriks commented May 23, 2020

Please backport

@CirnoT CirnoT deleted the editor-toolbar_transparent branch May 23, 2020 14:23
CirnoT added a commit to CirnoT/gitea that referenced this pull request May 23, 2020
@lafriks lafriks added the backport/done All backports for this PR have been created label May 23, 2020
techknowlogick pushed a commit that referenced this pull request May 23, 2020
…11583)

Co-authored-by: Lauris BH <[email protected]>
(cherry picked from commit 38c773d)

Co-authored-by: zeripath <[email protected]>
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants