Skip to content

Handle expected errors in AddGPGkey API (#11644) #11661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2020
Merged

Handle expected errors in AddGPGkey API (#11644) #11661

merged 1 commit into from
May 28, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented May 28, 2020

Backport #11644

  • handle GPG Parse & Email Errors

  • correct TEST

  • update Swagger

  • more Docu

@6543
Handle expected errors in AddGPGkey API (go-gitea#11644)
f2b80d1 
* handle GPG Parse & Email Errors

* correct TEST

* update Swagger

* more Docu
@6543 6543 mentioned this pull request May 28, 2020
Merged
@techknowlogick techknowlogick added the modifies/api This PR adds API routes or modifies them label May 28, 2020
@techknowlogick techknowlogick added this to the 1.12.0 milestone May 28, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 28, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 28, 2020
@techknowlogick techknowlogick merged commit 762c046 into go-gitea:release/v1.12 May 28, 2020
@zeripath zeripath deleted the backport_11644_api_gpg-handle-errors branch May 28, 2020 22:18
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.
4 participants
@6543 @techknowlogick @zeripath @GiteaBot