Update Octicons to v10

[silverwind]

Besides a few renames, these icons are no longer present in v10 that we've used, so had to change:

file-symlink-directory -> file-submodule
internal-repo -> repo
repo-force-push -> repo-push
repo-template-private -> repo-template

Fixes: #11889
Ref: https://github.com/primer/octicons/releases/tag/v10.0.0

[CirnoT]

repo-template-private -> repo-template
internal-repo -> repo

These two should be fine thanks to previous PRs that explicitly display repo visibility/type as label.

[CirnoT]

Index: templates/repo/header.tmpl
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- templates/repo/header.tmpl	(revision d6c55b0ab0130fca7d93b0ef52b1414e990b4e0a)
+++ templates/repo/header.tmpl	(date 1594663288676)
@@ -50,8 +50,7 @@
 						{{$.CsrfTokenHtml}}
 						<div class="ui labeled button" tabindex="0">
 							<button type="submit" class="ui compact basic button">
-								<!-- TODO use star-filled once octicons v2 are in place */ -->
-								{{if $.IsStaringRepo}}{{svg "octicon-star" 16}}{{$.i18n.Tr "repo.unstar"}}{{else}}{{svg "octicon-star" 16}}{{$.i18n.Tr "repo.star"}}{{end}}
+								{{if $.IsStaringRepo}}{{svg "octicon-star-fill" 16}}{{$.i18n.Tr "repo.unstar"}}{{else}}{{svg "octicon-star" 16}}{{$.i18n.Tr "repo.star"}}{{end}}
 							</button>
 							<a class="ui basic label" href="{{.Link}}/stars">
 								{{.NumStars}}

[silverwind]

Removed settings icon fixed:

[silverwind]

Admin dashboard now uses play:

[CirnoT]

Aside from octicon-mirror you should also update octicon-clone, as they're now same icon https://github.com/chromium/chromium

[silverwind]

You mean repo-clone? I guess I can add a copy gitea-repo-clone.

[CirnoT]

I think Octicons switched to single octicon-mirror icon (that is, repo-clone is removed) but mirror icon itself is missing from v10 for now so we don't know for sure. Based on GH usage however most likely we should just rename usages of octicon-repo-clone to octicon-mirror* as 99% in next version they'll remove clone and add mirror icon instead.

*- technically gitea-mirror

[silverwind]

I'll just move out current usage of repo-clone to gitea-mirror. If they decide to add octicon-mirror it'll be an easy switch for us.

[silverwind]

Done. I also changed to "New Migration" icon to repo-push which seemed more appropriate than the mirror icon:

[silverwind]

Conflicts were also using this repo-clone icon which when turned into a mirror icon seemed unfitting. Changed them to octicon-x:

[silverwind]

One more semi-related change. Timeline icons slightly adjusted and background of commit icon fixed:

[silverwind]

Comment button ... replaced with octicon and slightly tweaked:

[CirnoT]

Actually mirror octicon is in set; https://primer.style/octicons/mirror-16. Very sorry for suggesting that it isn't. We can remove gitea-mirror in that case.

[CirnoT]

Can't we use https://primer.style/octicons/tools-16 or https://primer.style/octicons/gear-16 instead of v1 sliders for settings?

[silverwind]

@CirnoT both done.

One more semi-related change: Replaced two icons on Wiki with octicons:

I think this is looking pretty good now overall.

[lafriks]

devDependencies are only for build tools, so it should be moved back to dependencies

[silverwind]

I've moved both svgo and @primer/octicons to devDependencies because they are not used during the main build process (only during the make svg task), but I guess it's probably better to have them in dependencies.

[lafriks]

svgo is used for building so it is devDependency but octicons are dependency

[silverwind]

They are both used in the same script so they shoud be together. Let's keep them in dependencies. The primary reason I've moved them to devDeps is to avoid some unnecessary installs but it's no big deal.

[lafriks]

@silverwind but not the same way. Svgo is used as a lib for build script while octicons are needed get svg files from so that's different uses

[silverwind]

Done, I guess I don't really care :)

[lafriks]

🚀