Skip to content

Fix line selection on blame view #12857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 15, 2020

Conversation

mrsdizzie
Copy link
Member

Blame and regular code view have diverged slightly so line highlighting wasn't working properly anymore. Make work again in lieu of a larger refactor of blame HTML to move it outside of source and into templates to match code view.

Fixes #12836

Blame and regular code view have diverge slightly so line highlighting wasn't working properly anymore. Make work again in lieu of a larger refactor of blame HTML to move it outside of source and into templates to match code view.

Fixes go-gitea#12836
@mrsdizzie mrsdizzie added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Sep 15, 2020
@mrsdizzie mrsdizzie added this to the 1.13.0 milestone Sep 15, 2020
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice workaround ;)

works

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Sep 15, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2020

Codecov Report

Merging #12857 into master will decrease coverage by 0.01%.
The diff coverage is 73.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12857      +/-   ##
==========================================
- Coverage   43.17%   43.16%   -0.02%     
==========================================
  Files         654      654              
  Lines       72218    72193      -25     
==========================================
- Hits        31182    31163      -19     
+ Misses      35985    35981       -4     
+ Partials     5051     5049       -2     
Impacted Files Coverage Δ
routers/user/notification.go 40.17% <0.00%> (-0.37%) ⬇️
services/pull/pull.go 41.27% <78.57%> (-0.30%) ⬇️
modules/git/repo.go 46.70% <0.00%> (-3.05%) ⬇️
modules/log/file.go 73.60% <0.00%> (-1.61%) ⬇️
models/repo_list.go 78.57% <0.00%> (-0.90%) ⬇️
services/pull/check.go 47.69% <0.00%> (-0.77%) ⬇️
modules/log/event.go 59.43% <0.00%> (+1.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d0ad28...5999eeb. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 15, 2020
@techknowlogick
Copy link
Member

🚀

@techknowlogick techknowlogick merged commit 88823f3 into go-gitea:master Sep 15, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blame table changing L# in URL to "undefined" rather than highlighting desired line
6 participants