Skip to content

Conversation

kolaente
Copy link
Member

@kolaente kolaente commented Oct 5, 2020

This PR fixes the Pull Request merge buttons on mobile devices. Especially for languages with longer button texts, this can look quite broken.

Before:
Screen Shot 2020-10-05 at 21 41 28

After:
Screen Shot 2020-10-05 at 21 39 11

@techknowlogick techknowlogick added the topic/ui Change the appearance of the Gitea UI label Oct 5, 2020
@techknowlogick techknowlogick added this to the 1.13.0 milestone Oct 5, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Oct 5, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #13035 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13035      +/-   ##
==========================================
- Coverage   42.62%   42.60%   -0.03%     
==========================================
  Files         672      672              
  Lines       73785    73785              
==========================================
- Hits        31448    31433      -15     
- Misses      37247    37256       +9     
- Partials     5090     5096       +6     
Impacted Files Coverage Δ
modules/indexer/stats/db.go 43.47% <0.00%> (-26.09%) ⬇️
modules/indexer/stats/queue.go 64.70% <0.00%> (-11.77%) ⬇️
modules/git/utils.go 73.77% <0.00%> (-3.28%) ⬇️
models/error.go 34.34% <0.00%> (-0.51%) ⬇️
modules/git/repo.go 46.19% <0.00%> (-0.51%) ⬇️
services/pull/pull.go 40.78% <0.00%> (-0.50%) ⬇️
services/pull/check.go 48.46% <0.00%> (+0.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e1c51c...543124b. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 5, 2020
@techknowlogick
Copy link
Member

🚀

@techknowlogick techknowlogick merged commit b5e76dd into go-gitea:master Oct 5, 2020
@kolaente kolaente deleted the fix/pr-merge-buttons branch October 6, 2020 16:40
@kolaente
Copy link
Member Author

kolaente commented Oct 6, 2020

Awesome, thanks for merging!

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants