Issue and Pulls lists rework

[silverwind]

Reorganized and restyled the issue and pull request lists.

[mrsdizzie]

This looks great could these be incorporated into https://github.com/go-gitea/gitea/blob/master/templates/user/dashboard/issues.tmpl too?

[silverwind]

@mrsdizzie did just that. It took a few if clauses because the pages did get slightly different template contexts.

[lunny]

The link for issue creator is not differ from other texts?

[silverwind]

It's following GitHub design where those links are also not colored unless hovered, I guess in an effort to focus the viewer on the issue title. I guess we could diverge from that design a bit as I generally think links should be distinguishable. Will think about it.

BTW I haven't really tested all the labels that can appear on the second line, but they are mostly copies from the old template (repo issue, not dashboard issue).

[6543]

what about using different octicons on pulls, so you know if it's a pull or an issue?

[silverwind]

what about using different octicons on pulls, so you know if it's a pull or an issue?

That should already be the case, see:

https://github.com/go-gitea/gitea/pull/13594/files#diff-511ca3487e2c8c1cb1c144ad5cfe6189bceb0da2ee7ae47d7ae578fa92e12cc3R13-R29

Edit: Add PR list sample to OP.

[silverwind]

@lunny I think it's fine if we not color those links for aesthetic reason and to draw the attention to the title instead.

[silverwind]

Milestone list fixed as well:

[silverwind]

While diffing the milestone list I found two differences to issue lists:

1. Milestones don't render below issue title on milestone list
2. The link on labels does not include the milestone=id query

I fixed those differences now by introducing a new merge template helper which is basically a superiour version of the dict helper which preserves the root "dict" and merges additional passed pairs into it. This will allow us to more easily consolidate slightly differing templates into the future.

[lafriks]

🚀