Skip to content

Diff and code review refactors and improvements #13922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 17, 2020
Merged

Diff and code review refactors and improvements #13922

merged 5 commits into from
Dec 17, 2020

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Dec 9, 2020 •
edited
Loading

  • Simplify Diff CSS styling and add color variables for diff.
  • Fix vertical centering of inline comment "show resolved" button.
  • Slightly adjust text colors, e.g. in comment header.
  • More CSS vars refactors.
  • Reduce paddings and fix border on arc-green on inline review box.
  • Fix color inconsistency on grey timeline badges.
  • Very slightly brighten timeline in arc-green.

Screen Shot 2020-12-16 at 00 20 23

Screen Shot 2020-12-16 at 00 20 31

Screen Shot 2020-12-16 at 00 20 52

Screen Shot 2020-12-16 at 00 21 00

Screen Shot 2020-12-09 at 23 17 29

Screen Shot 2020-12-09 at 23 13 16

Screen Shot 2020-12-15 at 00 53 34

Screen Shot 2020-12-15 at 00 53 13

Screen Shot 2020-12-15 at 00 47 08

Screen Shot 2020-12-15 at 00 46 55

silverwind
silverwind commented Dec 9, 2020
View reviewed changes
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 9, 2020
@silverwind silverwind added type/refactoring Existing code has been cleaned up. There should be no new functionality. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Dec 9, 2020
@silverwind silverwind added this to the 1.14.0 milestone Dec 10, 2020
@silverwind
Diff CSS refactors and misc tweaks
f85fe35 
- Simplify Diff CSS styling
- Add color variables for diff
- Fix vertical centering of inline comment button
- Slightly adjust text colors, e.g. in comment header
@silverwind silverwind changed the title Diff CSS refactors and misc tweaks Diff and code review refactors and improvements Dec 14, 2020
@silverwind
Copy link
Member Author

silverwind commented Dec 14, 2020 •
edited
Loading

Included a few more fixes and improvements for code review:

  • More CSS vars refactors.
  • Reduce paddings and fix border on arc-green on inline review box.
  • Fix color inconsistency on grey timeline badges.
  • Very slightly brighten timeline in arc-green.

Screenshots above are updated.

@silverwind
Copy link
Member Author

There's a regression on split diff left side background color, putton on draft til fix.

image

@silverwind silverwind marked this pull request as draft December 15, 2020 22:43
@silverwind
Copy link
Member Author

silverwind commented Dec 15, 2020 •
edited
Loading

Ok split diff should be sorted out. I Also happened to fix this split diff bug seen on master on gitea theme only:

https://try.gitea.io/silverwind/remap-css/commit/19283402eebd928cc8cde8ec1764520a764c648b?style=split

Screen Shot 2020-12-16 at 00 14 23

Screenshots updated once more.

@silverwind silverwind marked this pull request as ready for review December 15, 2020 23:17
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 17, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 17, 2020
@lunny
Copy link
Member

lunny commented Dec 17, 2020

make L-G-T-M work.

@lunny lunny merged commit 8af9df0 into go-gitea:master Dec 17, 2020
@silverwind silverwind deleted the csstweaks15 branch December 17, 2020 16:10
@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.
4 participants
@silverwind @lunny @6543 @GiteaBot