Skip to content

Fix import path #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix import path #140

wants to merge 1 commit into from

Conversation

thibaultmeyer
Copy link
Contributor

@thibaultmeyer thibaultmeyer commented Nov 11, 2016 •
edited
Loading

According to #135, this pull request fix all imports. Now the commands go get all and go build works like a charm.

Note: Please, don't hesitate to clone this branch to test in your own computer.

$ make build
go build -v -tags '' -ldflags '-s -w -X "github.com/go-gitea/gitea/modules/setting.BuildTime=2016-11-11 08:40:08 UTC" -X "github.com/go-gitea/gitea/modules/setting.BuildGitHash=243e0b5"' -o bin/gitea
github.com/go-gitea/gitea/models
github.com/go-gitea/gitea/modules/template
github.com/go-gitea/gitea/modules/auth
github.com/go-gitea/gitea/modules/cron
github.com/go-gitea/gitea/modules/ssh
github.com/go-gitea/gitea/routers/api/v1/convert
github.com/go-gitea/gitea/modules/context
github.com/go-gitea/gitea/routers/repo
github.com/go-gitea/gitea/routers/api/v1/misc
github.com/go-gitea/gitea/routers/dev
github.com/go-gitea/gitea/routers/user
github.com/go-gitea/gitea/routers/api/v1/repo
github.com/go-gitea/gitea/routers/api/v1/user
github.com/go-gitea/gitea/routers
github.com/go-gitea/gitea/routers/org
github.com/go-gitea/gitea/routers/api/v1/org
github.com/go-gitea/gitea/routers/api/v1/admin
github.com/go-gitea/gitea/routers/admin
github.com/go-gitea/gitea/routers/api/v1
github.com/go-gitea/gitea/cmd
github.com/go-gitea/gitea

$

@thibaultmeyer thibaultmeyer added this to the 1.0.0 milestone Nov 11, 2016
@thibaultmeyer thibaultmeyer added the issue/critical This issue should be fixed ASAP. If it is a PR, the PR should be merged ASAP label Nov 11, 2016
@strk
Copy link
Member

strk commented Nov 11, 2016

Sounds like a revert of #135, basically, no ?

@thibaultmeyer
Copy link
Contributor Author

Yeah, it seems that #135 not working rather than TravisCI return success (see comments from @tboerger on #135)

@strk strk mentioned this pull request Nov 11, 2016
Merged
@strk
Copy link
Member

strk commented Nov 11, 2016

See #141, should work once go-gitea/redirects#5 is merged

@strk strk closed this Nov 11, 2016
@lunny
Copy link
Member

lunny commented Nov 11, 2016

no. I think we should fix the wrong import path, not revert.

stevenroose
stevenroose reviewed Nov 12, 2016
View reviewed changes
models/issue.go
@@ -167,9 +167,9 @@ func (issue *Issue) HTMLURL() string {
// State returns string representation of issue status.
func (i *Issue) State() api.StateType {
if i.IsClosed {
return api.STATE_CLOSED
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes have nothing to do with import paths..

@tboerger tboerger added reviewed/invalid and removed type/bug issue/critical This issue should be fixed ASAP. If it is a PR, the PR should be merged ASAP labels Nov 12, 2016
@tboerger tboerger removed this from the 1.0.0 milestone Nov 12, 2016
@rchavik rchavik mentioned this pull request Aug 22, 2019
Closed
7 tasks
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
@delvh delvh added issue/not-a-bug The reported issue is the intended behavior or the problem is not inside Gitea and removed reviewed/invalid labels Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@stevenroose stevenroose stevenroose left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@lunny lunny

@tboerger tboerger

@strk strk

@thibaultmeyer thibaultmeyer

Labels
issue/not-a-bug The reported issue is the intended behavior or the problem is not inside Gitea
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@thibaultmeyer @strk @lunny @stevenroose @tboerger @delvh