Fix bug in commit verification introduced in #13673 #14040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a slight bug in the commit_reader introduced in go-gitea#13673 whereby commit messages which have a final unterminated line miss their final line. This PR fixes this. Signed-off-by: Andrew Thornton <[email protected]>
zeripath
added
type/bug
skip-changelog
jolheiser
approved these changes
Dec 17, 2020
GiteaBot
added
the
lgtm/need 1
6543
approved these changes
Dec 17, 2020
GiteaBot
added
lgtm/done
|
Sorry about that. |
6543
added a commit
to 6543-forks/gitea
that referenced
this pull request
Dec 17, 2020
6543
added a commit
that referenced
this pull request
Dec 21, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a slight bug in the commit_reader introduced in #13673 whereby
commit messages which have a final unterminated line miss their final line.
This PR fixes this.
Related #13673
Signed-off-by: Andrew Thornton [email protected]