Skip to content

[API] GetRelease by tag only return release #14397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 4, 2021
+8 −4
Merged

[API] GetRelease by tag only return release #14397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7882390
get release by tag should filter out tag releases to be consisten wit…
cameronbraid Jan 19, 2021
876d7b1
remove RepoID test
cameronbraid Jan 19, 2021
76da070
Merge branch 'master' into pr-2edf7af9-56b4-48f6-ace2-decb1a5eaa3b
lunny Jan 19, 2021
d3402e5
simplify & enhance
6543 Feb 4, 2021
1fc3ef4
Merge branch 'master' into pr-2edf7af9-56b4-48f6-ace2-decb1a5eaa3b
6543 Feb 4, 2021
e6ceff9
fix test
6543 Feb 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions integrations/api_releases_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ package integrations
import (
"fmt"
"net/http"
"strings"
"testing"

"code.gitea.io/gitea/models"
Expand Down Expand Up @@ -152,7 +151,7 @@ func TestAPIGetReleaseByTag(t *testing.T) {

var err *api.APIError
DecodeJSON(t, resp, &err)
assert.True(t, strings.HasPrefix(err.Message, "release tag does not exist"))
assert.EqualValues(t, "Not Found", err.Message)
}

func TestAPIDeleteTagByName(t *testing.T) {
Expand Down
9 changes: 7 additions & 2 deletions routers/api/v1/repo/release_tags.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,14 +48,19 @@ func GetReleaseTag(ctx *context.APIContext) {
release, err := models.GetRelease(ctx.Repo.Repository.ID, tag)
if err != nil {
if models.IsErrReleaseNotExist(err) {
ctx.Error(http.StatusNotFound, "GetRelease", err)
ctx.NotFound()
return
}
ctx.Error(http.StatusInternalServerError, "GetRelease", err)
return
}

if err := release.LoadAttributes(); err != nil {
if release.IsTag {
ctx.NotFound()
return
}

if err = release.LoadAttributes(); err != nil {
ctx.Error(http.StatusInternalServerError, "LoadAttributes", err)
return
}
Expand Down