Skip to content

Enable race detector for CI #1441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Aug 26, 2021
Merged

Enable race detector for CI #1441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
782b968
Enable race detector by default
typeless May 28, 2020
5b6bdaa
Disable race detector for release builds
typeless May 28, 2020
dd4674b
use `true`
6543 Jun 2, 2021
7694598
fix
6543 Jun 3, 2021
f280790
debug issue
6543 Jul 21, 2021
6118e40
fix
6543 Jul 21, 2021
54ddf05
verbose
6543 Jul 21, 2021
79b9228
clean
6543 Jul 21, 2021
8a969a1
Fix wrong merge
lunny Aug 25, 2021
e61f744
Merge branch 'main' into enable-race-detector-in-ci
6543 Aug 25, 2021
fbd09bc
Merge branch 'main' into enable-race-detector-in-ci
lunny Aug 26, 2021
89e19ef
Fix coverage merge
lunny Aug 26, 2021
c9eef66
Merge branch 'enable-race-detector-in-ci' of github.com:typeless/gite…
lunny Aug 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .drone.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,7 @@ steps:
environment:
GOPROXY: off
TAGS: bindata sqlite sqlite_unlock_notify
RACE_ENABLED: true
GITHUB_READ_TOKEN:
from_secret: github_read_token

Expand All @@ -236,6 +237,7 @@ steps:
environment:
GOPROXY: off
TAGS: bindata gogit sqlite sqlite_unlock_notify
RACE_ENABLED: true
GITHUB_READ_TOKEN:
from_secret: github_read_token

Expand All @@ -246,6 +248,7 @@ steps:
environment:
GOPROXY: off
TAGS: bindata
RACE_ENABLED: true
TEST_LDAP: 1
USE_REPO_TEST_DIR: 1
TEST_INDEXER_CODE_ES_URL: "http://elastic:changeme@elasticsearch:9200"
Expand All @@ -259,6 +262,7 @@ steps:
environment:
GOPROXY: off
TAGS: bindata
RACE_ENABLED: true
TEST_LDAP: 1
USE_REPO_TEST_DIR: 1
depends_on:
Expand All @@ -271,6 +275,7 @@ steps:
environment:
GOPROXY: off
TAGS: bindata
RACE_ENABLED: true
TEST_LDAP: 1
USE_REPO_TEST_DIR: 1
depends_on:
Expand Down Expand Up @@ -366,6 +371,7 @@ steps:
environment:
GOPROXY: off
TAGS: bindata gogit sqlite sqlite_unlock_notify
RACE_ENABLED: true
TEST_TAGS: gogit sqlite sqlite_unlock_notify
USE_REPO_TEST_DIR: 1
depends_on:
Expand All @@ -378,6 +384,7 @@ steps:
environment:
GOPROXY: off
TAGS: bindata gogit
RACE_ENABLED: true
TEST_TAGS: gogit
TEST_LDAP: 1
USE_REPO_TEST_DIR: 1
Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,7 +385,7 @@ test\#%:

.PHONY: coverage
coverage:
GO111MODULE=on $(GO) run -mod=vendor build/gocovmerge.go integration.coverage.out $(shell find . -type f -name "coverage.out") > coverage.all
GO111MODULE=on $(GO) run -mod=vendor build/gocovmerge.go integration.coverage.out coverage.out > coverage.all

.PHONY: unit-test-coverage
unit-test-coverage:
Expand Down
2 changes: 1 addition & 1 deletion build/gocovmerge.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ func main() {
for _, file := range flag.Args() {
profiles, err := cover.ParseProfiles(file)
if err != nil {
log.Fatalf("failed to parse profiles: %v", err)
log.Fatalf("failed to parse profile '%s': %v", file, err)
}
for _, p := range profiles {
merged = addProfile(merged, p)
Expand Down