Skip to content

Conversation

lunny
Copy link
Member

@lunny lunny commented Jan 27, 2021

Rename modules/middlewares to modules/web/middleware as well move it to web/ because there are two many packages below modules

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Jan 27, 2021
@lunny lunny mentioned this pull request Jan 27, 2021
@codecov-io
Copy link

codecov-io commented Jan 27, 2021

Codecov Report

Merging #14480 (8a5d9ee) into master (0e0424c) will increase coverage by 0.04%.
The diff coverage is 40.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14480      +/-   ##
==========================================
+ Coverage   42.15%   42.19%   +0.04%     
==========================================
  Files         762      762              
  Lines       81238    81238              
==========================================
+ Hits        34243    34280      +37     
+ Misses      41409    41373      -36     
+ Partials     5586     5585       -1     
Impacted Files Coverage Δ
modules/auth/sso/sso.go 26.92% <0.00%> (ø)
modules/forms/org.go 0.00% <0.00%> (ø)
modules/forms/user_form_auth_openid.go 0.00% <0.00%> (ø)
modules/web/middleware/binding.go 60.52% <ø> (ø)
modules/web/middleware/cookie.go 48.27% <ø> (ø)
modules/web/middleware/flash.go 56.52% <ø> (ø)
modules/web/middleware/locale.go 70.58% <ø> (ø)
modules/web/middleware/request.go 100.00% <ø> (ø)
routers/install.go 0.00% <0.00%> (ø)
routers/repo/pull.go 32.02% <0.00%> (ø)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e0424c...8a5d9ee. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 27, 2021
@lunny lunny force-pushed the lunny/rename_middlewares branch from e12d447 to 8e845df Compare January 27, 2021 15:08
@6543 6543 added this to the 1.14.0 milestone Jan 27, 2021
@6543 6543 added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jan 27, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 27, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 30, 2021
@lafriks lafriks merged commit 5e20fd6 into go-gitea:master Jan 30, 2021
a1012112796 added a commit to a1012112796/gitea that referenced this pull request Feb 3, 2021
* master: (28 commits)
  [Docs] Clone filters (go-gitea#14555)
  update docs to show latest stable version (1.13.2) (go-gitea#14550)
  Adding Chi's GetHead middleware (go-gitea#14541)
  Changelog v1.13.2 (go-gitea#14535) (go-gitea#14543)
  [skip ci] Updated translations via Crowdin
  [API] List, Check, Add & delete endpoints for repository teams (go-gitea#13630)
  [skip ci] Updated translations via Crowdin
  rm redirect (go-gitea#14534)
  Upgrade 'css-minimizer-webpack-plugin' to the latest version (go-gitea#14527)
  Set the name Mapper in migrations (go-gitea#14526)
  Internal ssh server respect Ciphers, MACs and KeyExchanges settings (go-gitea#14523)
  Move middlewares to web/middleware (go-gitea#14480)
  Add Doctor FixWrongUserType (go-gitea#14522)
  [skip ci] Updated translations via Crowdin
  noop (go-gitea#14521)
  Update docs and comments to remove macaron (go-gitea#14491)
  [skip ci] Updated translations via Crowdin
  Fix json charset bug (go-gitea#14514)
  enhancement: add signoff option in commit form (go-gitea#14516)
  Fix load time bug (go-gitea#14508)
  ...
@go-gitea go-gitea locked and limited conversation to collaborators Mar 11, 2021
@lunny lunny deleted the lunny/rename_middlewares branch August 24, 2023 11:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants