Skip to content

Fix github download on migration #14703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 18, 2021
Merged

Fix github download on migration #14703

merged 4 commits into from
Feb 18, 2021

Conversation

lunny
Copy link
Member

@lunny lunny commented Feb 17, 2021 •
edited
Loading

There are two changes on this PR to prevent wrong release download.

  • Use a local variable but a point of loop in the closure function
  • Refresh rate limit before and after downloading asset from Github

@lunny lunny added this to the 1.14.0 milestone Feb 17, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 17, 2021
@6543 6543 added the topic/repo-migration Migrate repos from other platforms to Gitea, or from Gitea to them label Feb 17, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 17, 2021
zeripath
zeripath reviewed Feb 17, 2021
View reviewed changes
zeripath
zeripath previously requested changes Feb 17, 2021
View reviewed changes
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as above

@zeripath zeripath dismissed their stale review February 17, 2021 23:01

Outdated

@6543 6543 merged commit ec06eb1 into go-gitea:master Feb 18, 2021
@lunny lunny deleted the lunny/fix_github_down branch February 18, 2021 01:13
@lunny
Copy link
Member Author

lunny commented Feb 18, 2021

It's unnecessary to backport this PR.

@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

+2 more reviewers

@gary-kim gary-kim gary-kim approved these changes

@zeripath zeripath zeripath left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/repo-migration Migrate repos from other platforms to Gitea, or from Gitea to them type/bug
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lunny @zeripath @6543 @gary-kim @GiteaBot