Add NOTICE-file and generator #1488
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkcsoft
added
type/docs
4 tasks
sapk
reviewed
Apr 13, 2017
| rm -f NOTICE # `govendor license` appends... | ||
| govendor license -o NOTICE +v | ||
|
|
||
| notice-up-to-date: NOTICE |
There was a problem hiding this comment.
Since it is a test maybe prepend it name with test- ? and add .PHONY just in case ?
There was a problem hiding this comment.
Maybe we could even used a more generic name like test-generate-diff and include generation of NOTICE in make generate or in go generate ?
|
I don't think that it makes sense to list all license files in detail. Beside that it's not properly formatted. A listing of the used licenses? Ok... But every license? Wtf? |
tboerger
added
the
lgtm/need 2
|
@tboerger It lists all vendored licenses. Anything that isn't vendored shouldn't be in use and vice versa :) |
|
@tboerger This is standard practice for larger projects though :/ |
bkcsoft
force-pushed
the
bkcsoft/makefile-notice
branch
from
77ae57d to
370e329
Compare
|
Why adding the NOTICE file at all if it can be generated from vendor/ directory ? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See title
@tboerger I think you have to create the .sig-file for Drone