Skip to content

response simple text message for not html request when 404 #15229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 1, 2021
Merged

response simple text message for not html request when 404 #15229

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3473477
response simple text message for not html request when response 404
a1012112796 Apr 1, 2021
24bfa21
Merge branch 'master' into simple-404
a1012112796 Apr 1, 2021
595457d
simple logic
a1012112796 Apr 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions modules/context/context.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,23 @@ func (ctx *Context) notFoundInternal(title string, err error) {
}
}

// response simple meesage if Accept isn't text/html
reqTypes, has := ctx.Req.Header["Accept"]
if has && len(reqTypes) > 0 {
notHTML := true
for _, part := range reqTypes {
if strings.Contains(part, "text/html") {
notHTML = false
break
}
}

if notHTML {
ctx.PlainText(404, []byte("Not found.\n"))
return
}
}

ctx.Data["IsRepo"] = ctx.Repo.Repository != nil
ctx.Data["Title"] = "Page Not Found"
ctx.HTML(http.StatusNotFound, base.TplName("status/404"))
Expand Down