Skip to content

Conversation

KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented Apr 3, 2021

Addition to 'Close file on invalid range #15166' with changes from #15166 (comment)

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 3, 2021
@techknowlogick techknowlogick added this to the 1.14.0 milestone Apr 3, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 6, 2021
@lunny
Copy link
Member

lunny commented Apr 6, 2021

make L-G-T-M work.

@lunny lunny merged commit 5f18404 into go-gitea:master Apr 6, 2021
KN4CK3R added a commit to KN4CK3R/gitea that referenced this pull request Apr 6, 2021
)

* Close file on invalid range.

* Close on seek error

Signed-off-by: Andrew Thornton <[email protected]>

* Moved 'Seek' into server.

* io.ReadSeekCloser is only available in Go 1.16

Co-authored-by: Andrew Thornton <[email protected]>
Co-authored-by: Lauris BH <[email protected]>
Co-authored-by: Lunny Xiao <[email protected]>
@zeripath zeripath modified the milestones: 1.14.0, 1.15.0 Apr 6, 2021
techknowlogick added a commit that referenced this pull request Apr 6, 2021
* Close file on invalid range.

* Close on seek error

Signed-off-by: Andrew Thornton <[email protected]>

* Moved 'Seek' into server.

* io.ReadSeekCloser is only available in Go 1.16

Co-authored-by: Andrew Thornton <[email protected]>
Co-authored-by: Lauris BH <[email protected]>
Co-authored-by: Lunny Xiao <[email protected]>

Co-authored-by: Andrew Thornton <[email protected]>
Co-authored-by: Lauris BH <[email protected]>
Co-authored-by: Lunny Xiao <[email protected]>
Co-authored-by: techknowlogick <[email protected]>
@KN4CK3R KN4CK3R deleted the fix-close-file-2 branch April 6, 2021 20:29
@6543 6543 added the backport/done All backports for this PR have been created label Apr 7, 2021
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants