Skip to content

Update JS dependencies #15591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 24, 2021
Merged

Update JS dependencies #15591

merged 5 commits into from
Apr 24, 2021

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Apr 22, 2021 •
edited
Loading

  • Update all JS dependencies
  • Regenerate SVGs
  • Remove unused postcss dependency
  • Remove removed webpack option

@silverwind silverwind added dependencies skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. and removed skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Apr 22, 2021
@6543 6543 added this to the 1.15.0 milestone Apr 22, 2021
@6543 6543 added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Apr 22, 2021
@6543
Copy link
Member

6543 commented Apr 22, 2021 •
edited
Loading

make frontend

will change package.json & package-lock.json
node v15.14.0
npm 7.10.0

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 22, 2021
@silverwind
Copy link
Member Author

silverwind commented Apr 22, 2021 •
edited
Loading

Issue is npm v7 which introduces lockfile format v2. I guess we may as well switch to npm v7 because node 16 ships with it now. Lockfile is backwards-compatible with npm v6 but does so via duplication.

@silverwind
Copy link
Member Author

@6543 try again

@silverwind
Copy link
Member Author

Bumped Node.js to 16 on CI which ships npm v7, eliminating the lockfile warning.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 22, 2021
@silverwind
Copy link
Member Author

silverwind commented Apr 22, 2021 •
edited
Loading

Drone build seems bugged or something, should be nothing related to this PR except maybe some issue related to the node:16 images.

Edit: Something about node:16 bugs out drone (maybe it can't pull new images?). Reverted to node 14 which drone seems happy about. We can keep it on 14 too, it doesn't really matter.

@silverwind silverwind force-pushed the deps-25 branch 2 times, most recently from 194ca28 to a4ec9d5 Compare April 22, 2021 18:33
@silverwind
Update JS dependencies
0bf5210 
- Update all JS dependencies
- Regenerate SVGs
- Remove unused postcss dependency
- Remove removed webpack option
@techknowlogick
Copy link
Member

@silverwind node:16 isn't an image (at least I haven't been able to do a docker pull locally or find it on the tags tab of https://hub.docker.com/_/node)

@silverwind
Copy link
Member Author

Ah, right. It usually takes them a few days to release new major version images.

@silverwind
Copy link
Member Author

silverwind commented Apr 23, 2021 •
edited
Loading

postcss added again as it is a peer dependency of cssnano which I seem to always forget. Also opened cssnano/cssnano#1056 to fix it on their side. Ultimately it does not matter with npm v7 because it will always install peerDependencies and it even worked in v6 because we have like 20 instances of postcss already in the dependency tree.

I plan to soon eliminate the css-related build modules and switch to esbuild for the CSS build.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 24, 2021
@lafriks lafriks merged commit ec69f34 into go-gitea:master Apr 24, 2021
@silverwind silverwind deleted the deps-25 branch April 24, 2021 22:24
@go-gitea go-gitea locked and limited conversation to collaborators Jun 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.
6 participants
@silverwind @6543 @techknowlogick @lafriks @GiteaBot @lunny