Skip to content

Conversation

jpraet
Copy link
Member

@jpraet jpraet commented Jun 27, 2021

Hi! 👋

My PRs. I've mainly been focusing on bugfixes and features that scratch our own itches with gitea at the company I work for.
But I should be able to make some time to test and review PRs as well!

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 27, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 27, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #16274 (a4f3755) into main (615001d) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16274      +/-   ##
==========================================
+ Coverage   45.37%   45.38%   +0.01%     
==========================================
  Files         709      709              
  Lines       83496    83496              
==========================================
+ Hits        37886    37897      +11     
+ Misses      39525    39520       -5     
+ Partials     6085     6079       -6     
Impacted Files Coverage Δ
services/mailer/mail_comment.go 77.77% <0.00%> (-7.41%) ⬇️
modules/avatar/avatar.go 47.72% <0.00%> (-4.55%) ⬇️
modules/queue/manager.go 65.53% <0.00%> (-2.83%) ⬇️
models/repo_list.go 77.04% <0.00%> (-0.78%) ⬇️
routers/api/v1/repo/pull.go 28.14% <0.00%> (-0.60%) ⬇️
services/pull/pull.go 41.99% <0.00%> (ø)
models/error.go 39.68% <0.00%> (+0.77%) ⬆️
models/notification.go 65.85% <0.00%> (+0.88%) ⬆️
modules/notification/mail/mail.go 36.27% <0.00%> (+0.98%) ⬆️
modules/notification/ui/ui.go 62.31% <0.00%> (+1.44%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 615001d...a4f3755. Read the comment docs.

@zeripath zeripath added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jun 27, 2021
@zeripath zeripath merged commit 2a98ec1 into go-gitea:main Jun 27, 2021
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - welcome :)

AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants