Skip to content

Conversation

luzpaz
Copy link
Contributor

@luzpaz luzpaz commented Jul 7, 2021

Found using codespell -q 3 -S ./options/locale,./vendor -L ba,pullrequest,pullrequests,readby

Found via `codespell -q 3 -S ./options/locale,./vendor -L ba,pullrequest,pullrequests,readby`
@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@9543e06). Click here to learn what that means.
The diff coverage is 8.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #16367   +/-   ##
=======================================
  Coverage        ?   45.51%           
=======================================
  Files           ?      709           
  Lines           ?    83755           
  Branches        ?        0           
=======================================
  Hits            ?    38124           
  Misses          ?    39497           
  Partials        ?     6134           
Impacted Files Coverage Δ
cmd/dump.go 0.91% <0.00%> (ø)
cmd/hook.go 0.00% <ø> (ø)
cmd/migrate_storage.go 0.00% <0.00%> (ø)
cmd/web_letsencrypt.go 0.00% <ø> (ø)
models/branches.go 44.71% <0.00%> (ø)
models/context.go 52.00% <ø> (ø)
models/error.go 39.68% <0.00%> (ø)
models/issue_comment.go 52.72% <ø> (ø)
models/issue_dependency.go 62.68% <ø> (ø)
models/login_source.go 28.64% <ø> (ø)
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9543e06...88f8829. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 7, 2021
@techknowlogick techknowlogick added the type/docs This PR mainly updates/creates documentation label Jul 7, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 8, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 8, 2021
@luzpaz
Copy link
Contributor Author

luzpaz commented Jul 8, 2021

Shall i squash the commits down? BTW, 'm submitting upstream fixes to the iframe-resizer lib as well soon.

@6543
Copy link
Member

6543 commented Jul 8, 2021

we do squash merge every pull @luzpaz so it's better to not squash so reviewers know what has changed.

thanks for asking and good to hear to see it upstream fixed too ;)

@6543 6543 merged commit e0296b6 into go-gitea:main Jul 8, 2021
@luzpaz luzpaz deleted the typos branch July 8, 2021 11:43
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
…gitea#16367)

* Fix various doc, user-facing, and source comment typos

Found via `codespell -q 3 -S ./options/locale,./vendor -L ba,pullrequest,pullrequests,readby`
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants