Add EdDSA JWT signing algorithm #16786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
GiteaBot
added
the
lgtm/need 2
KN4CK3R
approved these changes
Aug 24, 2021
GiteaBot
added
lgtm/need 1
|
Could you please fix the spelling error in |
|
@KN4CK3R tbh I'm not getting where is the typo. |
|
|
@KN4CK3R done, didn't see that whatsoever, the British scientists claim that it's enough to see the first and the last letter in the word to read it 😄 |
lunny
approved these changes
Aug 25, 2021
GiteaBot
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there.
Currently
EdDSAsigning algorithm is missing and this PR adds the support.Here are few links to RFCs:
https://www.iana.org/assignments/jose/jose.xhtml#web-signature-encryption-algorithms
https://datatracker.ietf.org/doc/html/rfc8037