Add namespace to global click event

[derekhu]

Sovle : #15687

[silverwind]

I don't understand the purpose of this change. What is that cleanhash class? I don't think we use it, so this change would effectively kill that click handler as it is.

[derekhu]

I don't understand the purpose of this change. What is that cleanhash class? I don't think we use it, so this change would effectively kill that click handler as it is.

Hi, cleanhash in $(document).on("click.cleanhash") is jQuery event namespace, it is not class etc.

As I mentioned in #15687, I don't want gitea to clean hash automaticly when I click the blank area of issue (after click some certain comment with note id in hash) . I want to keep the comment-link with note id in url#hash after click blank area of the issue. In my work, I offen open many tabs of issue, and with focused comment highlight and url#hash, I can quickly go back to work from issue to issue. And this is what the Gitlab default does.

Gitea, by default , will clean the hash when I click blank area just like Github does.

Also, Gitea provided super great custom way, to add my own js , including overwrite the whole index.js. So there is a way for me to turn off the default behavior.

If the global click event has jQuery's event namespace, then I don't have to overwrite the whole index.js, I only need to add my own js in footer.tmpl, and add simple line of code: $(document).off("click.cleanhash") to turn off the default behavior in my custom code. And Gitea keeps the same default behavior unchanged for other people.

That is the reason why I want to add event.namespace to global click event handle. without any other negative effects .

Thank you for the Great Gitea. It helps me a lot.

FYI: jQuery event.namespace
https://api.jquery.com/event.namespace/

[silverwind]

I see, wasn't aware of that jQuery feature. Do you think it can be done without jQuery too (feel free to replace .on with .addEventListener)? I don't like to deepen the integration with it any more and I think we should strive to eliminate the jQuery dependency eventually because the DOM APIs are sufficient and much faster.

[derekhu]

I see, wasn't aware of that jQuery feature. Do you think it can be done without jQuery too (feel free to replace .on with .addEventListener)? I don't like to deepen the integration with it any more and I think we should strive to eliminate the jQuery dependency eventually because the DOM APIs are sufficient and much faster.

yeah, I agree. remove jQuery just like github did. I am not a jQuery fan.

So when?

It seems that I have to continue to overwrite the whole index.js to turn off the feature of auto clean hash. Maybe for another months.
And keep overwriting each time after updating Gitea version.

it’s okay, I already did that. While the Gitea already provided great custom way.

thank you for the Great Gitea, again .

[silverwind]

I think I get it now what you want. You want to unregister our event handler in a userscript to implement custom behavior with hashes. While I think the best solution is probably to add a user-facing option, we simply don't have the infrastructure to support such options easily. What I could see being done is to use .addEventListener and expose the listener function on window, e.g.

window._listeners = {};
window._listeners.hashClickListener = () => {/* event handler here */};
document.addEventListener('click', window._listeners.hashClickListener);

That way, you could easily unregister it from userscripts.

[derekhu]

I think I get it now what you want. You want to unregister our event handler in a userscript to implement custom behavior with hashes. While I think the best solution is probably to add a user-facing option, we simply don't have the infrastructure to support such options easily. What I could see being done is to use .addEventListener and expose the listener function on windows, e.g.

window._listeners.hashClickListener = () => {}
document.addEventListener('click', window._listeners.hashClickListener);

That way, you could easily unregister it by name from userscripts.

Yeah. It’s a way. However global variables especially the handlers in window is what frontend programmers should avoid to. Gitea need to design the custom way of that properly. But it’s a way, if Gitea team can accept it, it is okay for me:-)

[silverwind]

Yeah, I don't like polluting window either. We already do it here for the code editor. Maybe there is a better way.

[6543]

Can you try to merge main into feature branch?

[wxiaoguang]

I think the behavior can be fixed by a capture event listener.

https://stackoverflow.com/questions/12462721/does-stoppropgation-stop-the-event-from-propagating-in-the-capture-phase

Then we do not need to add event namespaces one by one.

I will close this issue and PR, feel free to feedback.