Skip to content

Upgrade xorm to fix rows bug #17052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Upgrade xorm to fix rows bug #17052

wants to merge 2 commits into from

Conversation

lunny
Copy link
Member

@lunny lunny commented Sep 15, 2021

Fix #17030

@lunny lunny added this to the 1.16.0 milestone Sep 15, 2021
zeripath
zeripath approved these changes Sep 15, 2021
View reviewed changes
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. There's quite a few other changes in there. This is fine for the 1.16 but do we want to backport all of these to 1.15?

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Sep 15, 2021
@zeripath
Copy link
Contributor

These changes have also resulted in interface changes and our code will need to be updated.

It might be better to just backport the rows fix on to 1.2.2 instead.

@lunny
Copy link
Member Author

lunny commented Sep 15, 2021

These changes have also resulted in interface changes and our code will need to be updated.

It might be better to just backport the rows fix on to 1.2.2 instead.

OK. I will try to do that.

@lunny lunny mentioned this pull request Sep 15, 2021
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Sep 15, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 15, 2021
@lunny lunny mentioned this pull request Sep 16, 2021
Merged
@lunny lunny added the pr/wip This PR is not ready for review label Sep 17, 2021
zeripath
zeripath suggested changes Sep 17, 2021
View reviewed changes
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm gonna mark this as request changes so that re-review occurs when its ready.

@delvh
Copy link
Member

delvh commented Sep 18, 2021

@zeripath, Hasn't that already been fixed with #17059?
Or do you expect another solution?

@zeripath
Copy link
Contributor

I agree - I think the underlying problem has been solved but I think lunny might be keeping it open to test against the new xorm.

@zeripath zeripath closed this Oct 14, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
@lunny lunny deleted the lunny/fix_xorm branch June 3, 2022 12:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath requested changes

@axifive axifive axifive approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. pr/wip This PR is not ready for review type/bug
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.

runtime error: invalid memory address or nil pointer dereference
5 participants
@lunny @zeripath @delvh @axifive @GiteaBot