Prevent dangling cat-files … #17154
Closed
Prevent dangling cat-files … #17154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In go-gitea#17138 it appears that on Windows a git cat-file can fail to be killed. This PR attempts to prevent this by: 1. Using os.Pipes for the input - this should mean that the stdin is definitely closed. 2. If the cat-file is doesn't close properly it will attempt to kill it repeatedly logging this. Fix go-gitea#17138 Signed-off-by: Andrew Thornton <[email protected]>
|
This is WIP because the current mechanism for killing processes is racy! |
GiteaBot
added
the
lgtm/need 2
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Sep 25, 2021
Backport go-gitea#17154 In go-gitea#17138 it appears that on Windows a git cat-file can fail to be killed. This PR attempts to prevent this by: 1. Using os.Pipes for the input - this should mean that the stdin is definitely closed. 2. If the cat-file is doesn't close properly it will attempt to kill it repeatedly logging this. Fix go-gitea#17138 Signed-off-by: Andrew Thornton <[email protected]>
|
Have I said how much I hate our linter? |
zeripath
commented
Sep 25, 2021
zeripath
commented
Sep 25, 2021
lafriks
approved these changes
Sep 25, 2021
GiteaBot
added
lgtm/need 1
|
data race detected |
Signed-off-by: Andrew Thornton <[email protected]>
Signed-off-by: Andrew Thornton <[email protected]>
Signed-off-by: Andrew Thornton <[email protected]>
6543
approved these changes
Oct 6, 2021
GiteaBot
added
lgtm/done
|
@zeripath is this RP considered ready? |
|
@tomaswarynyca unfortunately this doesn't seem to solve the issue and I'm kinda stuck with what other ideas to try. |
|
I think #17125 may help us to detect what is really going on a bit better. |
|
This doesn't work and the original issue appears to have solved itself. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #17138 it appears that on Windows a git cat-file can fail to be killed.
This PR attempts to prevent this by:
Fix #17138
Signed-off-by: Andrew Thornton [email protected]