Skip to content

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Nov 3, 2021

As discussed in the backport PR

The newly added setting option ALLOWED_HOST_LIST for webhooks:

  • In 1.15, the default should be *
  • In 1.16 and later, the default should be external

This PR fixes the documents for 1.16 and later.

The original PR #17482 has been marked as breaking, so this PR can just skip-changelog

This PR should not be merged before the backport. If the backport is discarded, then this PR should also be discarded.

@wxiaoguang wxiaoguang added type/docs This PR mainly updates/creates documentation skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR labels Nov 3, 2021
@wxiaoguang wxiaoguang marked this pull request as draft November 3, 2021 05:14
@wxiaoguang wxiaoguang removed the status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR label Nov 6, 2021
@wxiaoguang wxiaoguang marked this pull request as ready for review November 6, 2021 10:22
@wxiaoguang wxiaoguang requested a review from lafriks November 6, 2021 10:23
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 6, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #17530 (1cb4407) into main (bd613c7) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #17530      +/-   ##
==========================================
+ Coverage   45.49%   45.50%   +0.01%     
==========================================
  Files         793      793              
  Lines       88811    88811              
==========================================
+ Hits        40401    40413      +12     
+ Misses      41897    41883      -14     
- Partials     6513     6515       +2     
Impacted Files Coverage Δ
modules/git/repo_base_nogogit.go 82.85% <0.00%> (-2.86%) ⬇️
modules/git/utils.go 68.05% <0.00%> (-2.78%) ⬇️
modules/process/manager.go 72.83% <0.00%> (-2.47%) ⬇️
services/pull/pull.go 41.78% <0.00%> (-0.41%) ⬇️
models/issue_comment.go 51.60% <0.00%> (-0.30%) ⬇️
models/notification.go 66.15% <0.00%> (+0.87%) ⬆️
modules/notification/ui/ui.go 62.31% <0.00%> (+1.44%) ⬆️
modules/queue/queue_channel.go 96.66% <0.00%> (+1.66%) ⬆️
modules/notification/mail/mail.go 38.23% <0.00%> (+2.94%) ⬆️
modules/queue/workerpool.go 52.29% <0.00%> (+4.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd613c7...1cb4407. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 6, 2021
@wxiaoguang wxiaoguang merged commit d168f04 into go-gitea:main Nov 8, 2021
@wxiaoguang wxiaoguang deleted the update-webhook-doc branch November 8, 2021 03:25
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
…n 1.15 and 1.16 (go-gitea#17530)

* fix documents for ALLOWED_HOST_LIST, its default value differs between 1.15 and 1.16
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants