Skip to content

Conversation

Gusted
Copy link
Contributor

@Gusted Gusted commented Nov 21, 2021

  • Don't rebuild the whole server when a developer is just modifying some
    _test.go file. The files won't go into the final binary so let's not watch for them.

- Don't rebuild the whole server when a developer is just modifying some
`_test.go` file. The files won't go into the final binary so let's not
watch for them.
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 21, 2021
@wxiaoguang
Copy link
Contributor

It seems that the LGTM bot sometimes stops working ... approve again may wake it up.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 21, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 22, 2021
@techknowlogick techknowlogick merged commit 58ff86e into go-gitea:main Nov 22, 2021
@techknowlogick techknowlogick added topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Nov 22, 2021
@techknowlogick techknowlogick added this to the 1.16.0 milestone Nov 22, 2021
@Gusted Gusted deleted the air-exclude-tests branch November 24, 2021 08:26
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants