Skip to content

Move repofiles from modules/repofiles to services/repository/files #17774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 24, 2021
Merged

Move repofiles from modules/repofiles to services/repository/files #17774

merged 5 commits into from
Nov 24, 2021

Conversation

lunny
Copy link
Member

@lunny lunny commented Nov 23, 2021 •
edited
Loading

Package services/repository/files will depend on package services/repository.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Nov 23, 2021
@lunny lunny changed the title Move repofiles from modules/repofiles to services/repofiles Move repofiles from modules/repofiles to services/repository/files Nov 23, 2021
@lunny lunny force-pushed the lunny/move_repofiles branch from 05797df to 38b4d8b Compare November 23, 2021 15:27
@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@754fdd8). Click here to learn what that means.
The diff coverage is 73.45%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #17774   +/-   ##
=======================================
  Coverage        ?   45.55%           
=======================================
  Files           ?      803           
  Lines           ?    89992           
  Branches        ?        0           
=======================================
  Hits            ?    40999           
  Misses          ?    42449           
  Partials        ?     6544
Impacted Files Coverage Δ
routers/api/v1/repo/status.go 57.14% <0.00%> (ø)
services/cron/tasks_basic.go 89.28% <ø> (ø)
services/cron/tasks_extended.go 70.16% <0.00%> (ø)
services/repository/check.go 0.00% <ø> (ø)
services/repository/files/diff.go 64.70% <ø> (ø)
services/repository/files/temp_repo.go 56.86% <ø> (ø)
services/repository/files/tree.go 81.35% <ø> (ø)
services/repository/files/upload.go 0.00% <ø> (ø)
routers/web/repo/editor.go 24.15% <33.33%> (ø)
modules/convert/pull.go 62.50% <50.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 754fdd8...36f81c1. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 24, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 24, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 24, 2021
@lunny lunny merged commit c97d66d into go-gitea:main Nov 24, 2021
@lunny lunny deleted the lunny/move_repofiles branch November 24, 2021 07:56
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@lunny @6543
Move repofiles from modules/repofiles to services/repository/files (g…
8e8597c 
…o-gitea#17774)

* Move repofiles from modules to services

* rename services/repository/repofiles -> services/repository/files

* Fix test

Co-authored-by: 6543 <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lunny @codecov-commenter @wxiaoguang @6543 @GiteaBot