Skip to content

Update reserved usernames list #18438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Mar 31, 2022
Merged

Update reserved usernames list #18438

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
6e634cb
Update reserved usernames list
Jan 28, 2022
0da0faf
Merge branch 'main' into update-reserved-usernames
Jan 28, 2022
71d3c3d
Remove entries
Jan 28, 2022
d22759c
Add `v2` as reserved username
Jan 31, 2022
4873b98
Merge branch 'main' into update-reserved-usernames
Jan 31, 2022
b8017ed
Merge branch 'main' into update-reserved-usernames
zeripath Mar 4, 2022
873c8ac
Merge branch 'main' into update-reserved-usernames
zeripath Mar 5, 2022
d6bf1f0
Merge branch 'main' into update-reserved-usernames
zeripath Mar 27, 2022
3963ca7
Merge branch 'main' into update-reserved-usernames
zeripath Mar 27, 2022
3fb6e2a
Merge branch 'main' into update-reserved-usernames
lunny Mar 28, 2022
3caf5f8
Fix test
Mar 28, 2022
b3ee342
Merge branch 'main' into update-reserved-usernames
wxiaoguang Mar 29, 2022
cafa43b
Merge branch 'main' into update-reserved-usernames
wxiaoguang Mar 29, 2022
3a08550
Merge branch 'main' into update-reserved-usernames
lunny Mar 29, 2022
0a86c98
Merge branch 'main' into update-reserved-usernames
wxiaoguang Mar 30, 2022
be59dc6
Merge branch 'main' into update-reserved-usernames
wxiaoguang Mar 30, 2022
63790a7
Merge branch 'main' into update-reserved-usernames
wxiaoguang Mar 31, 2022
0565fb0
Merge branch 'main' into update-reserved-usernames
wxiaoguang Mar 31, 2022
8834f69
Merge branch 'main' into update-reserved-usernames
wxiaoguang Mar 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 22 additions & 4 deletions integrations/user_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,23 +75,41 @@ func TestRenameReservedUsername(t *testing.T) {
defer prepareTestEnv(t)()

reservedUsernames := []string{
".",
"..",
".well-known",
"admin",
"api",
"assets",
"attachments",
"avatar",
"avatars",
"captcha",
"commits",
"debug",
"error",
"explore",
"help",
"install",
"favicon.ico",
"ghost",
"issues",
"login",
"manifest.json",
"metrics",
"milestones",
"new",
"notifications",
"org",
"pulls",
"raw",
"repo",
"template",
"user",
"repo-avatars",
"robots.txt",
"search",
"serviceworker.js",
"ssh_info",
"swagger.v1.json",
"user",
"v2",
}

session := loginUser(t, "user2")
Expand Down
10 changes: 4 additions & 6 deletions models/user/user.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -576,6 +576,7 @@ var (
"api",
"assets",
"attachments",
"avatar",
"avatars",
"captcha",
"commits",
Expand All @@ -584,26 +585,23 @@ var (
"explore",
"favicon.ico",
"ghost",
"help",
"install",
"issues",
"less",
"login",
"manifest.json",
"metrics",
"milestones",
"new",
"notifications",
"org",
"plugins",
"pulls",
"raw",
"repo",
"repo-avatars",
"robots.txt",
"search",
"serviceworker.js",
"stars",
"template",
"ssh_info",
"swagger.v1.json",
"user",
"v2",
}
Expand Down